Make abstract class package private to hide implementation details

Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>

Author: Weltraumschaf

src/main/java/io/securecodebox/persistence/defectdojo/model/BaseModel.java

@@ -4,11 +4,9 @@
 
 package io.securecodebox.persistence.defectdojo.model;
 
-import java.util.Map;
 import lombok.EqualsAndHashCode;
 
 @EqualsAndHashCode // FIXME: Implement hashCode/equals in inheritance is problematic https://www.artima.com/articles/how-to-write-an-equality-method-in-java (see https://github.com/secureCodeBox/defectdojo-client-java/issues/23)
-// FIXME: Class should be package private because implementation detail
-abstract public class BaseModel {
-  public abstract boolean equalsQueryString(Map<String, Object> queryParams);
+abstract class BaseModel implements Model {
+  // Class can be removed we remove @EqualsAndHashCode.
 }

src/main/java/io/securecodebox/persistence/defectdojo/model/Model.java

@@ -0,0 +1,10 @@
+package io.securecodebox.persistence.defectdojo.model;
+
+import java.util.Map;
+
+/**
+ * Interface for all models
+ */
+public interface Model {
+  boolean equalsQueryString(Map<String, Object> queryParams);
+}

src/main/java/io/securecodebox/persistence/defectdojo/service/GenericDefectDojoService.java

@@ -14,8 +14,8 @@
 import io.securecodebox.persistence.defectdojo.exception.LoopException;
 import io.securecodebox.persistence.defectdojo.http.Foo;
 import io.securecodebox.persistence.defectdojo.http.ProxyConfigFactory;
-import io.securecodebox.persistence.defectdojo.model.BaseModel;
 import io.securecodebox.persistence.defectdojo.model.Engagement;
+import io.securecodebox.persistence.defectdojo.model.Model;
 import io.securecodebox.persistence.defectdojo.model.Response;
 import lombok.Getter;
 import org.springframework.http.HttpEntity;
@@ -35,7 +35,7 @@
 import java.util.*;
 
 // FIXME: Should be package private bc implementation detail.
-abstract public class GenericDefectDojoService<T extends BaseModel> {
+public abstract class GenericDefectDojoService<T extends Model> {
     protected Config config;
 
     protected ObjectMapper objectMapper;