Skip to content

Commit d356905

Browse files
committed
#36 Use interface type instead of implementation in method signature
It should be avoided to use concrete implementations as types in an API, if there is an interface because this gives the oportunity to switch implementations at runtime w/o recompiling, whih is decoupling from implementation details. Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
1 parent ef4c9ca commit d356905

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/main/java/io/securecodebox/persistence/defectdojo/service/ImportScanService.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ public ImportScanResponse importScan(ScanFile scanFile, long engagementId, long
137137
return this.importScan(scanFile, engagementId, lead, currentDate, scanType, testType, options);
138138
}
139139

140-
public ImportScanResponse importScan(ScanFile scanFile, long engagementId, long lead, String currentDate, ScanType scanType, long testType, LinkedMultiValueMap<String, Object> options) {
140+
public ImportScanResponse importScan(ScanFile scanFile, long engagementId, long lead, String currentDate, ScanType scanType, long testType, MultiValueMap<String, Object> options) {
141141
options.add("engagement", Long.toString(engagementId));
142142

143143
return this.createFindings(scanFile, "import-scan", lead, currentDate, scanType, testType, options);
@@ -150,7 +150,7 @@ public ImportScanResponse reimportScan(ScanFile scanFile, long testId, long lead
150150
return this.reimportScan(scanFile, testId, lead, currentDate, scanType, testType, options);
151151
}
152152

153-
public ImportScanResponse reimportScan(ScanFile scanFile, long testId, long lead, String currentDate, ScanType scanType, long testType, LinkedMultiValueMap<String, Object> options) {
153+
public ImportScanResponse reimportScan(ScanFile scanFile, long testId, long lead, String currentDate, ScanType scanType, long testType, MultiValueMap<String, Object> options) {
154154
options.add("test", Long.toString(testId));
155155

156156
return this.createFindings(scanFile, "reimport-scan", lead, currentDate, scanType, testType, options);

0 commit comments

Comments
 (0)