Skip to content

Commit 4ca6ae6

Browse files
WeltraumschafManuelNeuer
authored andcommitted
#36 More fixme tags
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
1 parent ef29b61 commit 4ca6ae6

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/main/java/io/securecodebox/persistence/defectdojo/service/DefaultImportScanService.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,7 @@ private ImportScanResponse createFindings(ScanFile scanFile, String endpoint, lo
9393
new MappingJackson2HttpMessageConverter())
9494
);
9595

96+
// FIXME: Why do we use a multi value map here? Do we need multiple values for any given key?
9697
final var body = new LinkedMultiValueMap<String, Object>();
9798

9899
body.add("lead", Long.toString(lead));
@@ -102,6 +103,7 @@ private ImportScanResponse createFindings(ScanFile scanFile, String endpoint, lo
102103
body.add("skip_duplicates", "false");
103104
body.add("test_type", String.valueOf(testType));
104105

106+
// Avoid duplicate entries:
105107
for (final var optionName : options.keySet()) {
106108
body.remove(optionName);
107109
}
@@ -119,7 +121,7 @@ public String getFilename() {
119121
}
120122
};
121123

122-
// FIXME Why do we add the whole byte array resiurce here as object? Is not simply the file name sufficient here? Then we could use <String, String>
124+
// FIXME: Why do we add the whole byte array resiurce here as object? Is not simply the file name sufficient here? Then we could use <String, String>
123125
body.add("file", contentsAsResource);
124126

125127
// FIXME: We do not define the the type T of the body here!
@@ -130,7 +132,7 @@ public String getFilename() {
130132
throw new DefectDojoPersistenceException("Failed to attach findings to engagement.");
131133
}
132134
}
133-
135+
134136
/**
135137
* The DefectDojo Authentication Header
136138
*

0 commit comments

Comments
 (0)