Skip to content

Commit 292d810

Browse files
Light2Darksebbeutler
authored andcommitted
fix: absolute positioning of button and enable select all rows (marimo-team#5643)
## 📝 Summary <!-- Provide a concise summary of what this pull request is addressing. If this PR fixes any issues, list them here by number (e.g., Fixes marimo-team#123). --> - fixes absolute positioning of delete rows button - enable select and deselect all rows Previously: <img width="600" alt="CleanShot 2025-07-15 at 23 06 19" src="https://github.com/user-attachments/assets/f2a17dd2-718b-4c77-a5f3-187b0891b01f" /> Now: <img width="600" alt="CleanShot 2025-07-15 at 23 05 26" src="https://github.com/user-attachments/assets/87391c88-fa3f-470f-b077-5eef4219172d" /> ## 🔍 Description of Changes <!-- Detail the specific changes made in this pull request. Explain the problem addressed and how it was resolved. If applicable, provide before and after comparisons, screenshots, or any relevant details to help reviewers understand the changes easily. --> ## 📋 Checklist - [x] I have read the [contributor guidelines](https://github.com/marimo-team/marimo/blob/main/CONTRIBUTING.md). - [ ] For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on [Discord](https://marimo.io/discord?ref=pr), or the community [discussions](https://github.com/marimo-team/marimo/discussions) (Please provide a link if applicable). - [ ] I have added tests for the changes made. - [x] I have run the code and verified that it works as expected.
1 parent 32012b9 commit 292d810

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

frontend/src/plugins/impl/data-editor/glide-data-editor.tsx

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -572,7 +572,7 @@ export const GlideDataEditor = <T,>({
572572
};
573573

574574
return (
575-
<>
575+
<div className="relative">
576576
<ErrorBoundary>
577577
<DataEditor
578578
ref={dataEditorRef}
@@ -595,7 +595,6 @@ export const GlideDataEditor = <T,>({
595595
width={"100%"}
596596
rowMarkers={{
597597
kind: "both",
598-
headerDisabled: true,
599598
}}
600599
rowSelectionMode={"multi"}
601600
onCellEdited={onCellEdited}
@@ -615,13 +614,13 @@ export const GlideDataEditor = <T,>({
615614
variant="destructive"
616615
size="sm"
617616
disabled={selection.rows.length === 0}
618-
className="bottom-1 right-2 h-7"
617+
className="right-2 h-7"
619618
onClick={handleDeleteRows}
620619
>
621620
{selection.rows.length <= 1 ? "Delete row" : "Delete rows"}
622621
</Button>
623622
</div>
624-
</>
623+
</div>
625624
);
626625
};
627626

0 commit comments

Comments
 (0)