Skip to content

Option to see patterns #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bhavesh-banknovo opened this issue Jun 26, 2020 · 3 comments · Fixed by #32
Closed

Option to see patterns #31

bhavesh-banknovo opened this issue Jun 26, 2020 · 3 comments · Fixed by #32
Assignees
@seanprashad
Labels
feature request 💬

Comments

@bhavesh-banknovo
Copy link

Hey Sean, thank you for the list, it has been really helpful. I was wondering whether it would be possible to add a switch or something at the top to toggle on/off the pattern types for each question. Currently all the pattern types are hidden unless a user clicks check at the left. While hiding the pattern type is definitely useful, I imagine that there are quite a few people who may be trying to find questions for a certain pattern type. Hence the ability to toggle on/off the pattern types would be really useful. Thanks in advance!
@seanprashad
Copy link
Owner

Hey @bhavesh-banknovo 😁 I'm super happy to hear that you've found value from the list!

I totally agree with you that having a slider toggle of some sort to show/hide patterns at will is a fantastic idea. I'm going to look into this over the weekend and try to get some progress made on it. I am working full-time now so I'm usually jam packed during the weekdays but I know I should have implemented this sooner.

In the meantime, you can filter by pattern via the drop down list at under the Pattern category:

Screen Shot 2020-06-25 at 9 14 29 PM

@seanprashad seanprashad self-assigned this Jun 26, 2020
@seanprashad
Copy link
Owner

Related: #28

seanprashad pushed a commit that referenced this issue Jun 27, 2020
Add toggle to show/hide patterns
f7f512a 
Fixes #31
@seanprashad seanprashad mentioned this issue Jun 27, 2020
Merged
seanprashad pushed a commit that referenced this issue Jun 27, 2020
Add toggle to show/hide patterns (#32)
19dcb51 
Fixes #31
seanprashad pushed a commit that referenced this issue Jun 27, 2020
Show patterns by default
47e2414 
Follow-up to #31
@seanprashad seanprashad mentioned this issue Jun 27, 2020
Merged
seanprashad pushed a commit that referenced this issue Jun 27, 2020
Show patterns by default (#34)
4dfc0d4 
Follow-up to #31
@seanprashad
Copy link
Owner

seanprashad commented Jun 27, 2020 •
edited
Loading

Hey @bhavesh-banknovo! I'm happy to say that this has been implemented and you'll now see a toggle beside the Pattern column header:

image

Clicking on the toggle (or its label Show/Hide Patterns) will now toggle between being hiding or showing all patterns (all patterns are shown by default).

Please let me know if you find bugs of any sort ✌🏽

@seanprashad seanprashad mentioned this issue Jun 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seanprashad seanprashad

Labels
feature request 💬
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add toggle to show/hide patterns seanprashad/leetcode-patterns
2 participants
@seanprashad @bhavesh-banknovo