Skip to content

Ensure GitHub Pages redeploys after scheduled run-cron job #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
seanprashad opened this issue Aug 14, 2022 · 3 comments · Fixed by #236
Closed

Ensure GitHub Pages redeploys after scheduled run-cron job #234

seanprashad opened this issue Aug 14, 2022 · 3 comments · Fixed by #236
Labels
bug 👾

Comments

@seanprashad
Copy link
Owner

In 1f3beff, we run https://github.com/seanprashad/leetcode-patterns/blob/master/cron/update_questions.py via https://github.com/seanprashad/leetcode-patterns/blob/master/.github/workflows/run-cron.yml to update the companies on a weekly basis.

The problem is that we don't actually redeploy the updated website, which leads to two problems:

  1. Our companies tooltip doesn't automatically update
  2. The list of companies/question metadata is not pulled live from our gh-pages branch, and therefore still needs a manual deploy via npm run deploy
@seanprashad
Copy link
Owner Author

Look into triggering a second GitHub Action: https://stackoverflow.com/questions/62750603/github-actions-trigger-another-action-after-one-action-is-completed

Need to confirm, but we could do something like:

@seanprashad seanprashad changed the title Redeploy website after not updating via cron job Ensure GitHub Pages redeploys after scheduled run-cron job Aug 14, 2022
@seanprashad
Copy link
Owner Author

https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_run

seanprashad added a commit that referenced this issue Aug 14, 2022
@seanprashad
Ensure GitHub Pages redeploys after scheduled run-cron job
e0a4e53 
Fixes #234
@seanprashad seanprashad mentioned this issue Aug 14, 2022
Merged
seanprashad added a commit that referenced this issue Aug 14, 2022
@seanprashad
Ensure GitHub Pages redeploys after scheduled run-cron job (#236)
61fc54e 
Fixes #234
@seanprashad
Copy link
Owner Author

Working - see https://github.com/seanprashad/leetcode-patterns/actions/runs/2857435317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 👾
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure GitHub Pages redeploys after scheduled run-cron job seanprashad/leetcode-patterns
1 participant
@seanprashad