Skip to content

Support for Dark mode #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Shivam60 opened this issue Aug 4, 2021 · 13 comments
Closed

Support for Dark mode #110

Shivam60 opened this issue Aug 4, 2021 · 13 comments

Comments

@Shivam60
Copy link

Shivam60 commented Aug 4, 2021

As title says if site can have dark background it would be great.

@bharati-21
Copy link

I'd like to take it up! If possible, can this be assigned as a part of Hacktoberfest '21?

@seanprashad
Copy link
Owner

@bharati-21 Feel free to give it a shot! I was tinkering before with Styled Components but never got around to making the changes here. Please let me know if you have any questions!

@Shashank5665
Copy link
Contributor

Hello again @seanprashad !😁, is this still open? @bharati-21 did you complete this ?

@seanprashad
Copy link
Owner

Hey @Shashank5665! I think it's safe to consider this issue still open - feel free to take a crack at it. Note that it will be a little more difficult than your previous bug! Good luck!

@Shashank5665
Copy link
Contributor

Sure @seanprashad, I will definitely take a look at it.

@seanprashad seanprashad mentioned this issue May 29, 2024
@LordChakshu
Copy link
Contributor

Hey @seanprashad if this is open I would like to take it up!
Thanks.

@seanprashad
Copy link
Owner

Hey @LordChakshu - yes, feel free to pick this up. I should note that it is not as easy as it looks and will require a bit of work. Let me know if you have any questions - a lot of people would love to have this implemented!

@LordChakshu
Copy link
Contributor

@seanprashad could you suggest few color codes for dark mode.
This is what I have currently come up with
image

@seanprashad
Copy link
Owner

@LordChakshu Nice work! I think we can take inspiration from different Design Systems used at larger tech companies:

  1. Atlassian - Picking colors for dark mode
  2. Material Design - Dark theme

Feel free check out some of the colours from either of the above links - our main goal is to ensure readability for all content (i.e. hyperlinks, headers, buttons etc)!

@LordChakshu
Copy link
Contributor

Hey @seanprashad Above resources were quiet helpful, I was able to implement dark mode
I have attached snapshots.
Let me know If these are good to go.
Thanks
image
image
image
image

@seanprashad
Copy link
Owner

It looks fantastic @LordChakshu! When you're ready, feel free to open a pull request and I'll take a look sometime tomorrow/later this week. Thanks again for this amazing work!!

@LordChakshu
Copy link
Contributor

Hey @seanprashad I have raised PR for the same. Take a look at it whenever you get a chance.
Thanks.

@seanprashad
Copy link
Owner

Fixed with #323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants