-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Support for Dark mode #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'd like to take it up! If possible, can this be assigned as a part of Hacktoberfest '21? |
@bharati-21 Feel free to give it a shot! I was tinkering before with Styled Components but never got around to making the changes here. Please let me know if you have any questions! |
Hello again @seanprashad !😁, is this still open? @bharati-21 did you complete this ? |
Hey @Shashank5665! I think it's safe to consider this issue still open - feel free to take a crack at it. Note that it will be a little more difficult than your previous bug! Good luck! |
Sure @seanprashad, I will definitely take a look at it. |
Hey @seanprashad if this is open I would like to take it up! |
Hey @LordChakshu - yes, feel free to pick this up. I should note that it is not as easy as it looks and will require a bit of work. Let me know if you have any questions - a lot of people would love to have this implemented! |
@seanprashad could you suggest few color codes for dark mode. |
@LordChakshu Nice work! I think we can take inspiration from different Design Systems used at larger tech companies: Feel free check out some of the colours from either of the above links - our main goal is to ensure readability for all content (i.e. hyperlinks, headers, buttons etc)! |
Hey @seanprashad Above resources were quiet helpful, I was able to implement dark mode |
It looks fantastic @LordChakshu! When you're ready, feel free to open a pull request and I'll take a look sometime tomorrow/later this week. Thanks again for this amazing work!! |
Hey @seanprashad I have raised PR for the same. Take a look at it whenever you get a chance. |
Fixed with #323 |
As title says if site can have dark background it would be great.
The text was updated successfully, but these errors were encountered: