Add partial specs for Configuration

Still have to add specs for `merge` and `apply_environment!`.

Change-Id: I4be442c7eae7db4cb3298277cb7049565a1ed1f6
Reviewed-on: http://gerrit.causes.com/35574
Reviewed-by: Shane da Silva <shane@causes.com>
Tested-by: Shane da Silva <shane@causes.com>

Author: sds

lib/overcommit/configuration.rb

@@ -21,7 +21,7 @@ def enabled_builtin_hooks(hook_type)
     end
 
     # Returns a non-modifiable configuration for a hook.
-    def hook_config(hook, hook_type = nil)
+    def for_hook(hook, hook_type = nil)
       unless hook_type
         components = hook.class.name.split('::')
         hook = components.last
@@ -72,7 +72,7 @@ def hook_exists?(hook_type, hook_name)
     # possible.
     def validate
       @hash = convert_nils_to_empty_hashes(@hash)
-      ensure_special_all_section_exists(@hash)
+      ensure_hook_type_sections_exist(@hash)
     end
 
     def smart_merge(parent, child)
@@ -88,10 +88,9 @@ def smart_merge(parent, child)
       end
     end
 
-    def ensure_special_all_section_exists(hash)
-      hook_types = Dir[File.join(OVERCOMMIT_HOME, 'lib/overcommit/hook/*')].
-                     select { |path| File.directory?(path) }.
-                     map { |path| File.basename(path) }
+    def ensure_hook_type_sections_exist(hash)
+      hook_types = Overcommit::Utils.supported_hook_types.
+                                     map { |type| type.gsub('-', '_') }
 
       hook_types.each do |hook_type|
         hash[hook_type] ||= {}

lib/overcommit/hook/base.rb

@@ -8,7 +8,7 @@ class Base
     def_delegators :@context, :modified_files
 
     def initialize(config, context)
-      @config = config.hook_config(self)
+      @config = config.for_hook(self)
       @context = context
     end
 

lib/overcommit/utils.rb

@@ -30,8 +30,8 @@ def underscorize(str)
       # Returns a list of supported hook types (pre-commit, commit-msg, etc.)
       def supported_hook_types
         Dir[File.join(OVERCOMMIT_HOME, 'lib', 'overcommit', 'hook', '*')].
-          map { |file| File.basename(file, '.rb').gsub('_', '-') }.
-          reject { |file| file == 'base' }
+          select { |file| File.directory?(file) }.
+          map { |file| File.basename(file, '.rb').gsub('_', '-') }
       end
 
       # Returns whether a command can be found given the current environment path.

spec/overcommit/configuration_spec.rb

@@ -0,0 +1,98 @@
+require 'spec_helper'
+
+describe Overcommit::Configuration do
+  let(:hash) { {} }
+  let(:config) { described_class.new(hash) }
+
+  before do
+    Overcommit::Utils.instance_variable_set(:@repo_root, nil)
+  end
+
+  describe '#new' do
+    let(:internal_hash) { config.instance_variable_get(:@hash) }
+    subject { config }
+
+    context 'when no configuration exists for a hook type' do
+      it 'creates sections for those hook types' do
+        internal_hash.should have_key 'pre_commit'
+      end
+
+      it 'creates the special ALL section for the hook type' do
+        internal_hash['pre_commit'].should have_key 'ALL'
+      end
+    end
+
+    context 'when keys with empty values exist' do
+      let(:hash) do
+        {
+          'pre_commit' => {
+            'SomeHook' => nil
+          },
+        }
+      end
+
+      it 'converts the values to empty hashes' do
+        internal_hash['pre_commit']['SomeHook'].should == {}
+      end
+    end
+  end
+
+  describe '#plugin_directory' do
+    let(:hash) { { 'plugin_directory' => 'some-directory' } }
+    subject { config.plugin_directory }
+
+    around do |example|
+      repo do
+        example.run
+      end
+    end
+
+    it { should == File.expand_path('some-directory') }
+  end
+
+  describe '#enabled_builtin_hooks' do
+    let(:hash) do
+      {
+        'pre_commit' => {
+          'SomeHook' => nil,
+          'SomeOtherHook' => {
+            'enabled' => false
+          },
+        }
+      }
+    end
+
+    subject { config.enabled_builtin_hooks('pre_commit') }
+
+    it 'includes hooks that are not disabled' do
+      subject.should == ['SomeHook']
+    end
+  end
+
+  describe '#for_hook' do
+    let(:hash) do
+      {
+        'pre_commit' => {
+          'ALL' => {
+            'required' => false,
+          },
+          'SomeHook' => {
+            'enabled' => true,
+            'quiet' => false,
+          }
+        }
+      }
+    end
+
+    subject { config.for_hook('SomeHook', 'pre_commit') }
+
+    it 'returns the subset of the config for the specified hook' do
+      subject['enabled'].should be_true
+      subject['quiet'].should be_false
+    end
+
+    it 'merges the the hook config with the ALL section' do
+      subject['required'].should be_false
+    end
+  end
+end