Add specs for Configuration#apply_environment!

Change-Id: I4b9b8aeee0489079fa6772f7df800642db0df038
Reviewed-on: http://gerrit.causes.com/35576
Reviewed-by: Shane da Silva <shane@causes.com>
Tested-by: Shane da Silva <shane@causes.com>

Author: sds

lib/overcommit/configuration.rb

@@ -55,6 +55,7 @@ def apply_environment!(hook_type, env)
         @hash[hook_type]['ALL']['skip'] = true
       else
         skipped_hooks.select { |hook_name| hook_exists?(hook_type, hook_name) }.
+                      map { |hook_name| Overcommit::Utils.camel_case(hook_name) }.
                       each do |hook_name|
           @hash[hook_type][hook_name] ||= {}
           @hash[hook_type][hook_name]['skip'] = true
@@ -69,6 +70,8 @@ def apply_environment!(hook_type, env)
   private
 
     def hook_exists?(hook_type, hook_name)
+      hook_name = Overcommit::Utils.underscorize(hook_name)
+
       File.exist?(File.join(OVERCOMMIT_HOME, 'lib', 'overcommit', 'hook',
                             hook_type, "#{hook_name}.rb"))
     end

lib/overcommit/utils.rb

@@ -27,6 +27,11 @@ def underscorize(str)
             downcase
       end
 
+      # Converts a string containing underscores/hyphens/spaces into CamelCase.
+      def camel_case(str)
+        str.split(/_|-| /).map { |part| part.sub(/^\w/) { |c| c.upcase } }.join
+      end
+
       # Returns a list of supported hook types (pre-commit, commit-msg, etc.)
       def supported_hook_types
         Dir[File.join(OVERCOMMIT_HOME, 'lib', 'overcommit', 'hook', '*')].

spec/configuration_spec.rb

@@ -173,4 +173,71 @@
       end
     end
   end
+
+  describe '#apply_environment!' do
+    let(:hash) { {} }
+    let(:config) { described_class.new(hash) }
+    let!(:old_config) { described_class.new(hash.dup) }
+    subject { config }
+
+    before do
+      config.apply_environment!('pre-commit', env)
+    end
+
+    context 'when no hooks are requested to be skipped' do
+      let(:env) { {} }
+
+      it 'does nothing to the configuration' do
+        subject.should == old_config
+      end
+    end
+
+    context 'when a non-existent hook is requested to be skipped' do
+      let(:env) { { 'SKIP' => 'SomeMadeUpHook' } }
+
+      it 'does nothing to the configuration' do
+        subject.should == old_config
+      end
+    end
+
+    context 'when an existing hook is requested to be skipped' do
+      let(:env) { { 'SKIP' => 'AuthorName' } }
+
+      it 'sets the skip option of the hook to true' do
+        subject.for_hook('AuthorName', 'pre_commit')['skip'].should be_true
+      end
+
+      context 'and the hook is spelt with underscores' do
+        let(:env) { { 'SKIP' => 'author_name' } }
+
+        it 'sets the skip option of the hook to true' do
+          subject.for_hook('AuthorName', 'pre_commit')['skip'].should be_true
+        end
+      end
+
+      context 'and the hook is spelt with hyphens' do
+        let(:env) { { 'SKIP' => 'author-name' } }
+
+        it 'sets the skip option of the hook to true' do
+          subject.for_hook('AuthorName', 'pre_commit')['skip'].should be_true
+        end
+      end
+    end
+
+    context 'when the word "all" is included in the skip list' do
+      let(:env) { { 'SKIP' => 'all' } }
+
+      it 'sets the skip option of the ALL section to true' do
+        subject.for_hook('ALL', 'pre_commit')['skip'].should be_true
+      end
+
+      context 'and "all" is capitalized' do
+        let(:env) { { 'SKIP' => 'ALL' } }
+
+        it 'sets the skip option of the special ALL config to true' do
+          subject.for_hook('ALL', 'pre_commit')['skip'].should be_true
+        end
+      end
+    end
+  end
 end