Skip to content

Commit 806c246

Browse files
committed
Merged revisions 56753-56781 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/p3yk ................ r56760 | neal.norwitz | 2007-08-05 18:55:39 -0700 (Sun, 05 Aug 2007) | 178 lines Merged revisions 56477-56759 via svnmerge from svn+ssh://pythondev@svn.python.org/python/trunk ........ r56485 | facundo.batista | 2007-07-21 17:13:00 -0700 (Sat, 21 Jul 2007) | 5 lines Selectively enable tests for asyncore.readwrite based on the presence of poll support in the select module (since this is the only case in which readwrite can be called). [GSoC - Alan McIntyre] ........ r56488 | nick.coghlan | 2007-07-22 03:18:07 -0700 (Sun, 22 Jul 2007) | 1 line Add explicit relative import tests for runpy.run_module ........ r56509 | nick.coghlan | 2007-07-23 06:41:45 -0700 (Mon, 23 Jul 2007) | 5 lines Correctly cleanup sys.modules after executing runpy relative import tests Restore Python 2.4 ImportError when attempting to execute a package (as imports cannot be guaranteed to work properly if you try it) ........ r56519 | nick.coghlan | 2007-07-24 06:07:38 -0700 (Tue, 24 Jul 2007) | 1 line Tweak runpy test to do a better job of confirming that sys has been manipulated correctly ........ r56520 | nick.coghlan | 2007-07-24 06:58:28 -0700 (Tue, 24 Jul 2007) | 1 line Fix an incompatibility between the -i and -m command line switches as reported on python-dev by PJE - runpy.run_module now leaves any changes it makes to the sys module intact after the function terminates ........ r56523 | nick.coghlan | 2007-07-24 07:39:23 -0700 (Tue, 24 Jul 2007) | 1 line Try to get rid of spurious failure in test_resource on the Debian buildbots by changing the file size limit before attempting to close the file ........ r56533 | facundo.batista | 2007-07-24 14:20:42 -0700 (Tue, 24 Jul 2007) | 7 lines New tests for basic behavior of smtplib.SMTP and smtpd.DebuggingServer. Change to use global host & port number variables. Modified the 'server' to take a string to send back in order to vary test server responses. Added a test for the reaction of smtplib.SMTP to a non-200 HELO response. [GSoC - Alan McIntyre] ........ r56538 | nick.coghlan | 2007-07-25 05:57:48 -0700 (Wed, 25 Jul 2007) | 1 line More buildbot cleanup - let the OS assign the port for test_urllib2_localnet ........ r56539 | nick.coghlan | 2007-07-25 06:18:58 -0700 (Wed, 25 Jul 2007) | 1 line Add a temporary diagnostic message before a strange failure on the alpha Debian buildbot ........ r56543 | martin.v.loewis | 2007-07-25 09:24:23 -0700 (Wed, 25 Jul 2007) | 2 lines Change location of the package index to pypi.python.org/pypi ........ r56551 | georg.brandl | 2007-07-26 02:36:25 -0700 (Thu, 26 Jul 2007) | 2 lines tabs, newlines and crs are valid XML characters. ........ r56553 | nick.coghlan | 2007-07-26 07:03:00 -0700 (Thu, 26 Jul 2007) | 1 line Add explicit test for a misbehaving math.floor ........ r56561 | mark.hammond | 2007-07-26 21:52:32 -0700 (Thu, 26 Jul 2007) | 3 lines In consultation with Kristjan Jonsson, only define WINVER and _WINNT_WIN32 if (a) we are building Python itself and (b) no one previously defined them ........ r56562 | mark.hammond | 2007-07-26 22:08:54 -0700 (Thu, 26 Jul 2007) | 2 lines Correctly detect AMD64 architecture on VC2003 ........ r56566 | nick.coghlan | 2007-07-27 03:36:30 -0700 (Fri, 27 Jul 2007) | 1 line Make test_math error messages more meaningful for small discrepancies in results ........ r56588 | martin.v.loewis | 2007-07-27 11:28:22 -0700 (Fri, 27 Jul 2007) | 2 lines Bug #978833: Close https sockets by releasing the _ssl object. ........ r56601 | martin.v.loewis | 2007-07-28 00:03:05 -0700 (Sat, 28 Jul 2007) | 3 lines Bug #1704793: Return UTF-16 pair if unicodedata.lookup cannot represent the result in a single character. ........ r56604 | facundo.batista | 2007-07-28 07:21:22 -0700 (Sat, 28 Jul 2007) | 9 lines Moved all of the capture_server socket setup code into the try block so that the event gets set if a failure occurs during server setup (otherwise the test will block forever). Changed to let the OS assign the server port number, and client side of test waits for port number assignment before proceeding. The test data in DispatcherWithSendTests is also sent in multiple send() calls instead of one to make sure this works properly. [GSoC - Alan McIntyre] ........ r56611 | georg.brandl | 2007-07-29 01:26:10 -0700 (Sun, 29 Jul 2007) | 2 lines Clarify PEP 343 description. ........ r56614 | georg.brandl | 2007-07-29 02:11:15 -0700 (Sun, 29 Jul 2007) | 2 lines try-except-finally is new in 2.5. ........ r56617 | facundo.batista | 2007-07-29 07:23:08 -0700 (Sun, 29 Jul 2007) | 9 lines Added tests for asynchat classes simple_producer & fifo, and the find_prefix_at_end function. Check behavior of a string given as a producer. Added tests for behavior of asynchat.async_chat when given int, long, and None terminator arguments. Added usepoll attribute to TestAsynchat to allow running the asynchat tests with poll support chosen whether it's available or not (improves coverage of asyncore code). [GSoC - Alan McIntyre] ........ r56620 | georg.brandl | 2007-07-29 10:38:35 -0700 (Sun, 29 Jul 2007) | 2 lines Bug #1763149: use proper slice syntax in docstring. (backport) ........ r56624 | mark.hammond | 2007-07-29 17:45:29 -0700 (Sun, 29 Jul 2007) | 4 lines Correct use of Py_BUILD_CORE - now make sure it is defined before it is referenced, and also fix definition of _WIN32_WINNT. Resolves patch 1761803. ........ r56632 | facundo.batista | 2007-07-30 20:03:34 -0700 (Mon, 30 Jul 2007) | 8 lines When running asynchat tests on OS X (darwin), the test client now overrides asyncore.dispatcher.handle_expt to do nothing, since select.poll gives a POLLHUP error at the completion of these tests. Added timeout & count arguments to several asyncore.loop calls to avoid the possibility of a test hanging up a build. [GSoC - Alan McIntyre] ........ r56633 | nick.coghlan | 2007-07-31 06:38:01 -0700 (Tue, 31 Jul 2007) | 1 line Eliminate RLock race condition reported in SF bug #1764059 ........ r56636 | martin.v.loewis | 2007-07-31 12:57:56 -0700 (Tue, 31 Jul 2007) | 2 lines Define _BSD_SOURCE, to get access to POSIX extensions on OpenBSD 4.1+. ........ r56653 | facundo.batista | 2007-08-01 16:18:36 -0700 (Wed, 01 Aug 2007) | 9 lines Allow the OS to select a free port for each test server. For DebuggingServerTests, construct SMTP objects with a localhost argument to avoid abysmally long FQDN lookups (not relevant to items under test) on some machines that would cause the test to fail. Moved server setup code in the server function inside the try block to avoid the possibility of setup failure hanging the test. Minor edits to conform to PEP 8. [GSoC - Alan McIntyre] ........ r56681 | matthias.klose | 2007-08-02 14:33:13 -0700 (Thu, 02 Aug 2007) | 2 lines - Allow Emacs 22 for building the documentation in info format. ........ r56689 | neal.norwitz | 2007-08-02 23:46:29 -0700 (Thu, 02 Aug 2007) | 1 line Py_ssize_t is defined regardless of HAVE_LONG_LONG. Will backport ........ r56727 | hyeshik.chang | 2007-08-03 21:10:18 -0700 (Fri, 03 Aug 2007) | 3 lines Fix gb18030 codec's bug that doesn't map two-byte characters on GB18030 extension in encoding. (bug reported by Bjorn Stabell) ........ r56751 | neal.norwitz | 2007-08-04 20:23:31 -0700 (Sat, 04 Aug 2007) | 7 lines Handle errors when generating a warning. The value is always written to the returned pointer if getting it was successful, even if a warning causes an error. (This probably doesn't matter as the caller will probably discard the value.) Will backport. ........ ................
1 parent 1e8ce58 commit 806c246

35 files changed

+834
-331
lines changed

Doc/info/Makefile

+2-2
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,10 @@ $(WHATSNEW): python$(VERSION)-$(WHATSNEW).info
3434

3535
check-emacs-version:
3636
@v="`$(EMACS) --version 2>&1 | egrep '^(GNU |X)Emacs [12]*'`"; \
37-
if `echo "$$v" | grep '^GNU Emacs 21' >/dev/null 2>&1`; then \
37+
if `echo "$$v" | grep '^GNU Emacs 2[12]' >/dev/null 2>&1`; then \
3838
echo "Using $(EMACS) to build the info docs"; \
3939
else \
40-
echo "GNU Emacs 21 is required to build the info docs"; \
40+
echo "GNU Emacs 21 or 22 is required to build the info docs"; \
4141
echo "Found $$v"; \
4242
false; \
4343
fi

Doc/lib/librunpy.tex

+5-3
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,11 @@ \section{\module{runpy} ---
5656
If the argument \var{alter_sys} is supplied and evaluates to
5757
\code{True}, then \code{sys.argv[0]} is updated with the value of
5858
\code{__file__} and \code{sys.modules[__name__]} is updated with a
59-
temporary module object for the module being executed. Both
60-
\code{sys.argv[0]} and \code{sys.modules[__name__]} are restored to
61-
their original values before the function returns.
59+
new module object for the module being executed. Note that neither
60+
\code{sys.argv[0]} nor \code{sys.modules[__name__]} are restored to
61+
their original values before the function returns - if client code
62+
needs these values preserved, it must either save them explicitly or
63+
else avoid enabling the automatic alterations to \module{sys}.
6264

6365
Note that this manipulation of \module{sys} is not thread-safe. Other
6466
threads may see the partially initialised module, as well as the

Doc/lib/libxmlrpclib.tex

+2-1
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,8 @@ \section{\module{xmlrpclib} --- XML-RPC client access}
9494
\samp{>}, and \samp{\&} will be automatically escaped. However, it's
9595
the caller's responsibility to ensure that the string is free of
9696
characters that aren't allowed in XML, such as the control characters
97-
with ASCII values between 0 and 31; failing to do this will result in
97+
with ASCII values between 0 and 31 (except, of course, tab, newline and
98+
carriage return); failing to do this will result in
9899
an XML-RPC request that isn't well-formed XML. If you have to pass
99100
arbitrary strings via XML-RPC, use the \class{Binary} wrapper class
100101
described below.

Doc/tut/tut.tex

+3-1
Original file line numberDiff line numberDiff line change
@@ -3748,7 +3748,9 @@ \section{Defining Clean-up Actions \label{cleanup}}
37483748
\keyword{finally} clause has been executed. The \keyword{finally} clause
37493749
is also executed ``on the way out'' when any other clause of the
37503750
\keyword{try} statement is left via a \keyword{break}, \keyword{continue}
3751-
or \keyword{return} statement. A more complicated example:
3751+
or \keyword{return} statement. A more complicated example (having
3752+
\keyword{except} and \keyword{finally} clauses in the same \keyword{try}
3753+
statement works as of Python 2.5):
37523754
37533755
\begin{verbatim}
37543756
>>> def divide(x, y):

Doc/whatsnew/whatsnew25.tex

+18-9
Original file line numberDiff line numberDiff line change
@@ -640,15 +640,20 @@ \section{PEP 343: The 'with' statement\label{pep-343}}
640640
\end{verbatim}
641641

642642
The expression is evaluated, and it should result in an object that
643-
supports the context management protocol. This object may return a
644-
value that can optionally be bound to the name \var{variable}. (Note
645-
carefully that \var{variable} is \emph{not} assigned the result of
646-
\var{expression}.) The object can then run set-up code
647-
before \var{with-block} is executed and some clean-up code
648-
is executed after the block is done, even if the block raised an exception.
643+
supports the context management protocol (that is, has \method{__enter__()}
644+
and \method{__exit__()} methods.
649645

650-
To enable the statement in Python 2.5, you need
651-
to add the following directive to your module:
646+
The object's \method{__enter__()} is called before \var{with-block} is
647+
executed and therefore can run set-up code. It also may return a value
648+
that is bound to the name \var{variable}, if given. (Note carefully
649+
that \var{variable} is \emph{not} assigned the result of \var{expression}.)
650+
651+
After execution of the \var{with-block} is finished, the object's
652+
\method{__exit__()} method is called, even if the block raised an exception,
653+
and can therefore run clean-up code.
654+
655+
To enable the statement in Python 2.5, you need to add the following
656+
directive to your module:
652657

653658
\begin{verbatim}
654659
from __future__ import with_statement
@@ -668,9 +673,13 @@ \section{PEP 343: The 'with' statement\label{pep-343}}
668673
\end{verbatim}
669674

670675
After this statement has executed, the file object in \var{f} will
671-
have been automatically closed, even if the 'for' loop
676+
have been automatically closed, even if the \keyword{for} loop
672677
raised an exception part-way through the block.
673678

679+
\note{In this case, \var{f} is the same object created by
680+
\function{open()}, because \method{file.__enter__()} returns
681+
\var{self}.}
682+
674683
The \module{threading} module's locks and condition variables
675684
also support the '\keyword{with}' statement:
676685

Include/structmember.h

+2-1
Original file line numberDiff line numberDiff line change
@@ -68,11 +68,12 @@ typedef struct PyMemberDef {
6868
#ifdef HAVE_LONG_LONG
6969
#define T_LONGLONG 17
7070
#define T_ULONGLONG 18
71-
#define T_PYSSIZET 19 /* Py_ssize_t */
7271
#endif /* HAVE_LONG_LONG */
7372

73+
#define T_PYSSIZET 19 /* Py_ssize_t */
7474
#define T_NONE 20 /* Value is always None */
7575

76+
7677
/* Flags */
7778
#define READONLY 1
7879
#define RO READONLY /* Shorthand */

Lib/asynchat.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ def handle_read (self):
104104
if not terminator:
105105
# no terminator, collect it all
106106
self.collect_incoming_data (self.ac_in_buffer)
107-
self.ac_in_buffer = ''
107+
self.ac_in_buffer = b''
108108
elif isinstance(terminator, int) or isinstance(terminator, int):
109109
# numeric terminator
110110
n = terminator

Lib/distutils/command/register.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ class register(Command):
2222

2323
description = ("register the distribution with the Python package index")
2424

25-
DEFAULT_REPOSITORY = 'http://www.python.org/pypi'
25+
DEFAULT_REPOSITORY = 'http://pypi.python.org/pypi'
2626

2727
user_options = [
2828
('repository=', 'r',

Lib/distutils/command/upload.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ class upload(Command):
2020

2121
description = "upload binary package to PyPI"
2222

23-
DEFAULT_REPOSITORY = 'http://www.python.org/pypi'
23+
DEFAULT_REPOSITORY = 'http://pypi.python.org/pypi'
2424

2525
user_options = [
2626
('repository=', 'r',

Lib/httplib.py

+3
Original file line numberDiff line numberDiff line change
@@ -1129,6 +1129,9 @@ def recv(self, len = 1024, flags = 0):
11291129
def __getattr__(self, attr):
11301130
return getattr(self._sock, attr)
11311131

1132+
def close(self):
1133+
SharedSocketClient.close(self)
1134+
self._ssl = None
11321135

11331136
class HTTPSConnection(HTTPConnection):
11341137
"This class allows communication via SSL."

Lib/runpy.py

+14-26
Original file line numberDiff line numberDiff line change
@@ -33,36 +33,21 @@ def _run_code(code, run_globals, init_globals,
3333
return run_globals
3434

3535
def _run_module_code(code, init_globals=None,
36-
mod_name=None, mod_fname=None,
37-
mod_loader=None, alter_sys=False):
36+
mod_name=None, mod_fname=None,
37+
mod_loader=None, alter_sys=False):
3838
"""Helper for run_module"""
3939
# Set up the top level namespace dictionary
4040
if alter_sys:
41-
# Modify sys.argv[0] and sys.module[mod_name]
42-
temp_module = imp.new_module(mod_name)
43-
mod_globals = temp_module.__dict__
44-
saved_argv0 = sys.argv[0]
45-
restore_module = mod_name in sys.modules
46-
if restore_module:
47-
saved_module = sys.modules[mod_name]
41+
# Modify sys.argv[0] and sys.modules[mod_name]
4842
sys.argv[0] = mod_fname
49-
sys.modules[mod_name] = temp_module
50-
try:
51-
_run_code(code, mod_globals, init_globals,
52-
mod_name, mod_fname, mod_loader)
53-
finally:
54-
sys.argv[0] = saved_argv0
55-
if restore_module:
56-
sys.modules[mod_name] = saved_module
57-
else:
58-
del sys.modules[mod_name]
59-
# Copy the globals of the temporary module, as they
60-
# may be cleared when the temporary module goes away
61-
return mod_globals.copy()
43+
module = imp.new_module(mod_name)
44+
sys.modules[mod_name] = module
45+
mod_globals = module.__dict__
6246
else:
6347
# Leave the sys module alone
64-
return _run_code(code, {}, init_globals,
65-
mod_name, mod_fname, mod_loader)
48+
mod_globals = {}
49+
return _run_code(code, mod_globals, init_globals,
50+
mod_name, mod_fname, mod_loader)
6651

6752

6853
# This helper is needed due to a missing component in the PEP 302
@@ -84,10 +69,13 @@ def run_module(mod_name, init_globals=None,
8469
"""
8570
loader = get_loader(mod_name)
8671
if loader is None:
87-
raise ImportError("No module named " + mod_name)
72+
raise ImportError("No module named %s" % mod_name)
73+
if loader.is_package(mod_name):
74+
raise ImportError(("%s is a package and cannot " +
75+
"be directly executed") % mod_name)
8876
code = loader.get_code(mod_name)
8977
if code is None:
90-
raise ImportError("No code object available for " + mod_name)
78+
raise ImportError("No code object available for %s" % mod_name)
9179
filename = _get_filename(loader, mod_name)
9280
if run_name is None:
9381
run_name = mod_name

Lib/smtpd.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ def push(self, msg):
132132

133133
# Implementation of base class abstract method
134134
def collect_incoming_data(self, data):
135-
self.__line.append(data)
135+
self.__line.append(str(data, "utf8"))
136136

137137
# Implementation of base class abstract method
138138
def found_terminator(self):

Lib/smtplib.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -344,11 +344,11 @@ def getreply(self):
344344
self.file = self.sock.makefile('rb')
345345
while 1:
346346
line = self.file.readline()
347-
if line == '':
347+
if not line:
348348
self.close()
349349
raise SMTPServerDisconnected("Connection unexpectedly closed")
350350
if self.debuglevel > 0: print('reply:', repr(line), file=stderr)
351-
resp.append(line[4:].strip(b' \t\n'))
351+
resp.append(line[4:].strip(b' \t\r\n'))
352352
code=line[:3]
353353
# Check that the error code is syntactically correct.
354354
# Don't attempt to read a continuation line if it is broken.
@@ -358,7 +358,7 @@ def getreply(self):
358358
errcode = -1
359359
break
360360
# Check if multiline response.
361-
if line[3:4]!="-":
361+
if line[3:4] != b"-":
362362
break
363363

364364
errmsg = b"\n".join(resp)

0 commit comments

Comments
 (0)