closes bpo-39803: Remove unused str from _PyLong_FormatAdvancedWriter. (pythonGH-18709)

petdance · web-flow · commit 3fe9117779f0 · 2020-03-01T13:26:43.000-08:00
diff --git a/Python/formatter_unicode.c b/Python/formatter_unicode.c
@@ -1458,7 +1458,7 @@ _PyLong_FormatAdvancedWriter(_PyUnicodeWriter *writer,
                              PyObject *format_spec,
                              Py_ssize_t start, Py_ssize_t end)
 {
-    PyObject *tmp = NULL, *str = NULL;
+    PyObject *tmp = NULL;
     InternalFormatSpec format;
     int result = -1;
 
@@ -1511,7 +1511,6 @@ _PyLong_FormatAdvancedWriter(_PyUnicodeWriter *writer,
 
 done:
     Py_XDECREF(tmp);
-    Py_XDECREF(str);
     return result;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1458,7 +1458,7 @@ _PyLong_FormatAdvancedWriter(_PyUnicodeWriter *writer,`
`1458`	`1458`	`PyObject *format_spec,`
`1459`	`1459`	`Py_ssize_t start, Py_ssize_t end)`
`1460`	`1460`	`{`
`1461`		`- PyObject tmp = NULL, str = NULL;`
	`1461`	`+ PyObject *tmp = NULL;`
`1462`	`1462`	`InternalFormatSpec format;`
`1463`	`1463`	`int result = -1;`
`1464`	`1464`
`@@ -1511,7 +1511,6 @@ _PyLong_FormatAdvancedWriter(_PyUnicodeWriter *writer,`
`1511`	`1511`
`1512`	`1512`	`done:`
`1513`	`1513`	`Py_XDECREF(tmp);`
`1514`		`- Py_XDECREF(str);`
`1515`	`1514`	`return result;`
`1516`	`1515`	`}`
`1517`	`1516`