Got rid of mappers, shoppingCartRepository and query handlers

Author: oskardudycz

samples/unwrapping_onion/src/unpeeled/ecommerce/app.ts

@@ -1,10 +1,8 @@
 import { getApplication } from '#core/api';
 import { MongoClient } from 'mongodb';
-import registerHandlers from './shoppingCarts/application';
 import { getControllers } from './shoppingCarts/controllers';
 
 const initApp = (mongo: MongoClient) => {
-  registerHandlers(mongo);
   return getApplication(getControllers(mongo));
 };
 

samples/unwrapping_onion/src/unpeeled/ecommerce/shoppingCarts/application/index.ts

@@ -1,11 +1,7 @@
 import { EventBusFactory } from '#core/events';
-import { QueryBusFactory } from '#core/queries';
 import { MongoClient } from 'mongodb';
 import { ShoppingCartController } from './shoppingCartController';
 
 export const getControllers = (mongo: MongoClient) => {
-  return [
-    new ShoppingCartController(mongo, EventBusFactory(), QueryBusFactory())
-      .router,
-  ];
+  return [new ShoppingCartController(mongo, EventBusFactory()).router];
 };

samples/unwrapping_onion/src/unpeeled/ecommerce/shoppingCarts/application/queryHandlers/getCustomerShoppingHistoryHandler.ts

@@ -18,21 +18,14 @@ import {
   RemoveProductItemFromShoppingCart,
   ConfirmShoppingCart,
 } from '../commands';
-import { getCollection } from '#core/repositories';
-import {
-  getShoppingCart,
-  store,
-} from '../infrastructure/shoppingCartRepository';
+import { getById, getCollection } from '#core/repositories';
+import { findAllByCustomerId, getShoppingCart, store } from '../storage';
 
 export class ShoppingCartController {
   public router = Router();
   private carts: Collection<ShoppingCartModel>;
 
-  constructor(
-    mongo: MongoClient,
-    private eventBus: EventBus,
-    private queryBus: QueryBus
-  ) {
+  constructor(mongo: MongoClient, private eventBus: EventBus) {
     this.carts = getCollection<ShoppingCartModel>(mongo, 'shoppingCarts');
     this.router.post('/customers/:customerId/shopping-carts/', this.open);
     this.router.post(
@@ -109,7 +102,7 @@ export class ShoppingCartController {
 
       const event = aggregate.addProductItem(command.data.productItem);
 
-      await store(this.carts, event, aggregate);
+      await store(this.carts, event);
       await this.eventBus.publish(event);
 
       response.sendStatus(200);
@@ -142,7 +135,7 @@ export class ShoppingCartController {
 
       const event = aggregate.removeProductItem(command.data.productItem);
 
-      await store(this.carts, event, aggregate);
+      await store(this.carts, event);
       await this.eventBus.publish(event);
 
       response.sendStatus(200);
@@ -171,7 +164,7 @@ export class ShoppingCartController {
 
       const event = aggregate.confirm();
 
-      await store(this.carts, event, aggregate);
+      await store(this.carts, event);
       await this.eventBus.publish(event);
 
       response.sendStatus(200);
@@ -190,7 +183,7 @@ export class ShoppingCartController {
       const query = new GetShoppingCartById(
         assertNotEmptyString(request.params.shoppingCartId)
       );
-      const result = await this.queryBus.query(query);
+      const result = await getById(this.carts, query.shoppingCartId);
 
       response.send(result);
     } catch (error) {
@@ -208,7 +201,7 @@ export class ShoppingCartController {
       const query = new GetCustomerShoppingHistory(
         assertNotEmptyString(request.params.customerId)
       );
-      const result = await this.queryBus.query(query);
+      const result = await findAllByCustomerId(this.carts, query.customerId);
 
       response.send(result);
     } catch (error) {

samples/unwrapping_onion/src/unpeeled/ecommerce/shoppingCarts/application/queryHandlers/getShoppingCartByIdQueryHandler.ts

@@ -9,11 +9,8 @@ import {
 export class ShoppingCart {
   public constructor(
     public id: string,
-    public customerId: string,
     public status: string,
-    public productItems: ProductItem[],
-    public openedAt: Date,
-    public confirmedAt: Date | undefined,
+    public productItems: Map<string, number>,
     public revision: number
   ) {}
 
@@ -54,12 +51,9 @@ export class ShoppingCart {
 
     const { productId, quantity } = productItemToRemove;
 
-    const currentProductItem = this.findProductItem(
-      this.productItems,
-      productId
-    );
+    const currentQuantity = this.productItems.get(productId);
 
-    const newQuantity = (currentProductItem?.quantity ?? 0) - quantity;
+    const newQuantity = (currentQuantity ?? 0) - quantity;
 
     if (newQuantity < 0) throw new Error('Product Item not found');
 
@@ -85,13 +79,6 @@ export class ShoppingCart {
       },
     };
   }
-
-  private findProductItem(
-    productItems: ProductItem[],
-    productId: string
-  ): ProductItem | undefined {
-    return productItems.find((pi) => pi.productId === productId);
-  }
 }
 
 export const ShoppingCartStatus = {