Skip to content

Commit 0e61ae7

Browse files
committedAug 31, 2016
1) Update readme file credits and go report badge added; 2) Remove use less function; 3) Update test file.
1 parent 3c4ad28 commit 0e61ae7

8 files changed

+41
-10
lines changed
 

‎LICENSE.md

+27
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
Copyright (c) 2016, Ri Xu
2+
All rights reserved.
3+
4+
Redistribution and use in source and binary forms, with or without
5+
modification, are permitted provided that the following conditions are met:
6+
7+
* Redistributions of source code must retain the above copyright notice, this
8+
list of conditions and the following disclaimer.
9+
10+
* Redistributions in binary form must reproduce the above copyright notice,
11+
this list of conditions and the following disclaimer in the documentation
12+
and/or other materials provided with the distribution.
13+
14+
* Neither the name of [project] nor the names of its
15+
contributors may be used to endorse or promote products derived from
16+
this software without specific prior written permission.
17+
18+
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
19+
AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
20+
IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
21+
DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
22+
FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
23+
DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
24+
SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
25+
CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
26+
OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
27+
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

‎README.md

+5
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
[![Build Status](https://travis-ci.org/Luxurioust/excelize.svg?branch=master)](https://travis-ci.org/Luxurioust/excelize)
66
[![Code Coverage](https://codecov.io/gh/Luxurioust/excelize/branch/master/graph/badge.svg)](https://codecov.io/gh/Luxurioust/excelize)
7+
[![Go Report Card](https://goreportcard.com/badge/github.com/Luxurioust/excelize)](https://goreportcard.com/report/github.com/Luxurioust/excelize)
78
[![GoDoc](https://godoc.org/github.com/Luxurioust/excelize?status.svg)](https://godoc.org/github.com/Luxurioust/excelize)
89
[![Licenses](https://img.shields.io/badge/license-bsd-orange.svg)](https://opensource.org/licenses/BSD-3-Clause)
910
[![Join the chat at https://gitter.im/xuri-excelize/Lobby](https://img.shields.io/badge/GITTER-join%20chat-green.svg)](https://gitter.im/xuri-excelize/Lobby)
@@ -79,6 +80,10 @@ func main() {
7980

8081
Contributions are welcome! Open a pull request to fix a bug, or open an issue to discuss a new feature or change.
8182

83+
### Credits
84+
85+
Some struct of XML originally by [tealeg/xlsx](https://github.com/tealeg/xlsx).
86+
8287
## Licenses
8388

8489
This program is under the terms of the BSD 3-Clause License. See [https://opensource.org/licenses/BSD-3-Clause](https://opensource.org/licenses/BSD-3-Clause).

‎excelize_test.go

+1
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ func TestExcelize(t *testing.T) {
4141
if err != nil {
4242
t.Error(err)
4343
}
44+
GetCellValue(file, "Sheet2", "a-1")
4445
GetCellValue(file, "Sheet2", "a5")
4546
GetCellValue(file, "Sheet2", "D11")
4647
GetCellValue(file, "Sheet2", "D12")

‎lib.go

-10
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import (
66
"io"
77
"log"
88
"math"
9-
"os"
109
"regexp"
1110
"strconv"
1211
"strings"
@@ -100,15 +99,6 @@ func titleToNumber(s string) int {
10099
return sum - 1
101100
}
102101

103-
// Check the file exists
104-
func pathExist(_path string) bool {
105-
_, err := os.Stat(_path)
106-
if err != nil && os.IsNotExist(err) {
107-
return false
108-
}
109-
return true
110-
}
111-
112102
// Split Excel sheet column title to string and integer, return XAxis
113103
func getColIndex(axis string) string {
114104
r, err := regexp.Compile(`[^\D]`)

‎xmlContentTypes.go

+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
// Some code of this file reference tealeg/xlsx
2+
13
package excelize
24

35
import (

‎xmlSharedStrings.go

+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
// Some code of this file reference tealeg/xlsx
2+
13
package excelize
24

35
import (

‎xmlWorkbook.go

+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
// Some code of this file reference tealeg/xlsx
2+
13
package excelize
24

35
import (

‎xmlWorksheet.go

+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
// Some code of this file reference tealeg/xlsx
2+
13
package excelize
24

35
import (

0 commit comments

Comments
 (0)
Please sign in to comment.