Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split run-make test suite into slower-building test suite with suitably-staged cargo and faster-building test suite without cargo #847

Open
1 of 3 tasks
jieyouxu opened this issue Mar 9, 2025 · 2 comments
Labels
final-comment-period The FCP has started, most (if not all) team members are in agreement major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@jieyouxu
Copy link
Member

jieyouxu commented Mar 9, 2025

Proposal

Split run-make test suite into two test suites to allow contributors to not have to build cargo if the run-make test doesn't need it:

  1. A "slow" test suite that requires building a suitably-staged cargo, and thus allowing cargo() usages.
  2. A "fast" test suite that does not build cargo.

rustc-dev-guide and test suite README doc updates will be provided alongside the implementation PR(s).

See also rust-lang/rust#134109 and rust-lang/rust#135573.

Unresolved questions

How to distinguish between "minimal" and "full" configuration?

After discussion, I decided to make this distinction "build cargo or not".

Naming

I decided to constrain this MCP to focus on doing the functional test suite splitting. Naming is orthogonal.

I will go with {run-make,run-make-cargo} for now.

Mentors or Reviewers

The implementation will be bootstrap reviews primarily, MCP is for figuring out a naming scheme / vibe check / for awareness, really.

cc @WaffleLapkin who didn't really like that the run-make test suite is still called run-make when there's no make involved (understandably :D).

cc @petrochenkov, @bjorn3 and @RalfJung who asked about if it's possible/planned to not have to fully build cargo (which takes a good while).

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

@jieyouxu jieyouxu added major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team labels Mar 9, 2025
@rustbot
Copy link
Collaborator

rustbot commented Mar 9, 2025

Important

This issue is not meant to be used for technical discussion. There is a Zulip stream for that.
Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

Concerns or objections can formally be registered here by adding a comment.

@rfcbot concern reason-for-concern
<description of the concern>

Concerns can be lifted with:

@rfcbot resolve reason-for-concern

See documentation at https://forge.rust-lang.org

cc @rust-lang/compiler

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Mar 9, 2025
@jieyouxu jieyouxu changed the title Split run-make test suite into fast test suite (minimal tools) and slow test suite (full tools) Split run-make test suite into slower-building test suite with suitably-staged cargo and faster-building test suite without cargo Mar 10, 2025
@Kobzol
Copy link
Contributor

Kobzol commented Mar 20, 2025

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Mar 20, 2025
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
final-comment-period The FCP has started, most (if not all) team members are in agreement major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Development

No branches or pull requests

4 participants