Split run-make
test suite into slower-building test suite with suitably-staged cargo and faster-building test suite without cargo
#847
Labels
final-comment-period
The FCP has started, most (if not all) team members are in agreement
major-change
A proposal to make a major change to rustc
T-compiler
Add this label so rfcbot knows to poll the compiler team
Proposal
Split
run-make
test suite into two test suites to allow contributors to not have to build cargo if the run-make test doesn't need it:cargo()
usages.rustc-dev-guide and test suite README doc updates will be provided alongside the implementation PR(s).
See also rust-lang/rust#134109 and rust-lang/rust#135573.
Unresolved questions
How to distinguish between "minimal" and "full" configuration?
After discussion, I decided to make this distinction "build cargo or not".
Naming
I decided to constrain this MCP to focus on doing the functional test suite splitting. Naming is orthogonal.
I will go with
{run-make,run-make-cargo}
for now.Mentors or Reviewers
The implementation will be bootstrap reviews primarily, MCP is for figuring out a naming scheme / vibe check / for awareness, really.
cc @WaffleLapkin who didn't really like that the
run-make
test suite is still calledrun-make
when there's nomake
involved (understandably :D).cc @petrochenkov, @bjorn3 and @RalfJung who asked about if it's possible/planned to not have to fully build cargo (which takes a good while).
Process
The main points of the Major Change Process are as follows:
@rustbot second
.-C flag
, then full team check-off is required.@rfcbot fcp merge
on either the MCP or the PR.You can read more about Major Change Proposals on forge.
The text was updated successfully, but these errors were encountered: