Skip to content

Commit 1dee4ab

Browse files
committed
Add t-compiler triage meetings 01/25
1 parent 2b94acb commit 1dee4ab

5 files changed

+1255
-0
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,82 @@
1+
---
2+
tags: weekly, rustc
3+
type: docs
4+
note_id: OYXFrqEcTiuIRyZA0mjU-Q
5+
---
6+
7+
# T-compiler Meeting Agenda 2025-01-02
8+
9+
## Announcements
10+
11+
- Next week release of rustc stable 1.84
12+
13+
### P-high regressions
14+
15+
[P-high beta regressions](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3Aregression-from-stable-to-beta+label%3AP-high+-label%3AT-infra+-label%3AT-libs+-label%3AT-libs-api+-label%3AT-release+-label%3AT-rustdoc+-label%3AT-core)
16+
- "regression: ICE: `tcx.extern_crate(LocalCrate)` is not supported for this key" [rust#134705](https://github.com/rust-lang/rust/issues/134705)
17+
- Regression found in latest beta crater run, solved by #133585 ([beta-backport approved](https://rust-lang.zulipchat.com/#narrow/channel/238009-t-compiler.2Fmeetings/topic/.5Bweekly.5D.202024-12-26/near/490872595))
18+
19+
[Unassigned P-high nightly regressions](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3Aregression-from-stable-to-nightly+label%3AP-high+no%3Aassignee+-label%3AT-infra+-label%3AT-libs+-label%3AT-libs-api+-label%3AT-release+-label%3AT-rustdoc+-label%3AT-core+)
20+
- No unassigned `P-high` nightly regressions this time.
21+
22+
## Performance logs
23+
24+
> [triage logs for 2024-12-30](https://github.com/rust-lang/rustc-perf/blob/master/triage/2024-12-30.md)
25+
26+
A pretty quiet week, with the exception of a significant improvement due to
27+
landing LTO for C / C++ programs compiled as part of the build.
28+
29+
Triage done by **@simulacrum**.
30+
Revision range: [0eca4dd3..93722f7e](https://perf.rust-lang.org/?start=0eca4dd3205a01dba4bd7b7c140ec370aff03440&end=93722f7ed56bcf27839a6355074095c4320b7d37&absolute=false&stat=instructions%3Au)
31+
32+
**Summary**:
33+
34+
| (instructions:u) | mean | range | count |
35+
|:------------------------:|:-----:|:--------------:|:-----:|
36+
| Regressions (primary) | - | - | 0 |
37+
| Regressions (secondary) | - | - | 0 |
38+
| Improvements (primary) | -0.6% | [-5.6%, -0.2%] | 265 |
39+
| Improvements (secondary) | -0.7% | [-1.8%, -0.2%] | 187 |
40+
| All (primary) | -0.6% | [-5.6%, -0.2%] | 265 |
41+
42+
0 Regressions, 1 Improvements, 1 Mixed; 0 of them in rollups
43+
53 artifact comparisons made in total
44+
45+
#### Regressions
46+
47+
No meaningful regressions this week.
48+
49+
#### Improvements
50+
51+
CI: Add LTO support to clang in dist-x86_64-linux [#134690](https://github.com/rust-lang/rust/pull/134690) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=dd84b7d5eec3c20d7fcd13e6450af029d3cece9d&end=ecc189922dac830ff866f4609311e6afcc4a91f6&stat=instructions:u)
52+
53+
| (instructions:u) | mean | range | count |
54+
|:----------------------------------:|:-----:|:--------------:|:-----:|
55+
| Regressions (primary) | - | - | 0 |
56+
| Regressions (secondary) | - | - | 0 |
57+
| Improvements (primary) | -0.7% | [-5.5%, -0.3%] | 275 |
58+
| Improvements (secondary) | -0.9% | [-2.6%, -0.2%] | 235 |
59+
| All (primary) | -0.7% | [-5.5%, -0.3%] | 275 |
60+
61+
#### Mixed
62+
63+
Consider empty-unreachable otherwise branches in MatchBranchSimplification [#131244](https://github.com/rust-lang/rust/pull/131244) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=8b3f7ac5262531aefa227f90387cf2eb34aae800&end=4e0bc490c60d3588f3ec0aa2eee2cf0696c7c333&stat=instructions:u)
64+
65+
| (instructions:u) | mean | range | count |
66+
|:----------------------------------:|:-----:|:--------------:|:-----:|
67+
| Regressions (primary) | 0.2% | [0.2%, 0.2%] | 1 |
68+
| Regressions (secondary) | 0.3% | [0.2%, 0.3%] | 4 |
69+
| Improvements (primary) | -0.6% | [-0.7%, -0.5%] | 2 |
70+
| Improvements (secondary) | -0.2% | [-0.3%, -0.1%] | 2 |
71+
| All (primary) | -0.3% | [-0.7%, 0.2%] | 3 |
72+
73+
## Nominated Issues
74+
75+
[T-compiler](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AI-compiler-nominated)
76+
- "Built-in attributes are treated differently vs prelude attributes, unstable built-in attributes can name-collide with stable macro, and built-in attributes can break back-compat" [rust#134963](https://github.com/rust-lang/rust/issues/134963)
77+
- Nominated by @**Jieyou Xu**, suggests not requiring immediate attention, can be postponed to next week
78+
79+
[RFC](https://github.com/rust-lang/rfcs/issues?q=is%3Aopen+label%3AI-compiler-nominated)
80+
- No I-compiler-nominated RFCs this time.
81+
82+
Next meetings' agenda draft: [hackmd link](https://hackmd.io/EA9mhXkIR8muLGlnLyQ8Ug)

0 commit comments

Comments
 (0)