Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ruby/rdoc
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v6.3.2
Choose a base ref
...
head repository: ruby/rdoc
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v6.3.3
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on Nov 11, 2021

  1. Vertical-bar is disallowed in path names on Windows 

    No risk of remote code execution, when the file cannot be created.

https://github.com/ruby/rdoc/runs/2565343916?check_suite_focus=true#step:5:58
```
Error: test_remove_unparseable_CVE_2021_31799(TestRDocRDoc): Errno::EINVAL: Invalid argument @ utime_failed - | touch evil.txt && echo tags
D:/rubyinstaller-head-x64/lib/ruby/3.1.0/fileutils.rb:1142:in `utime'
D:/rubyinstaller-head-x64/lib/ruby/3.1.0/fileutils.rb:1142:in `block in touch'
D:/rubyinstaller-head-x64/lib/ruby/3.1.0/fileutils.rb:1139:in `each'
D:/rubyinstaller-head-x64/lib/ruby/3.1.0/fileutils.rb:1139:in `touch'
D:/a/rdoc/rdoc/test/rdoc/test_rdoc_rdoc.rb:463:in `block (2 levels) in test_remove_unparseable_CVE_2021_31799'
     460:     temp_dir do
     461:       file_list = ['| touch evil.txt && echo tags']
     462:       file_list.each do |f|
  => 463:         FileUtils.touch f
     464:       end
     465:
     466:       assert_equal file_list, @rdoc.remove_unparseable(file_list)
```
    @nobu @hsbt
    nobu authored and hsbt committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    61414e4 View commit details
    Browse the repository at this point in the history

  2. Bump rdoc version to 6.3.3

    @hsbt
    hsbt committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    4797136 View commit details
    Browse the repository at this point in the history
Loading