Skip to content

Combine Elsif node with IfNode #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 8, 2023
Merged

Combine Elsif node with IfNode #299

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4d9227e
Combine Elsif node into IfNode
egiurleo Feb 8, 2023
2d45da0
Remove Elsif method from DSL
egiurleo Feb 8, 2023
57b0306
Remove `visit_elsif` methods from all visitors
egiurleo Feb 8, 2023
17539d0
Update yarv compiler and decompiler to stop using Elsif node
egiurleo Feb 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove Elsif method from DSL 
And add `beginning` kwarg to `IfNode` DSL method.
  • Loading branch information
@egiurleo
egiurleo committed Mar 3, 2023
commit 2d45da0819764c098711b1923b80e8bba510929e
13 changes: 2 additions & 11 deletions lib/syntax_tree/dsl.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,16 +347,6 @@ def Else(keyword, statements)
)
end

# Create a new Elsif node.
def Elsif(predicate, statements, consequent)
Elsif.new(
predicate: predicate,
statements: statements,
consequent: consequent,
location: Location.default
)
end

# Create a new EmbDoc node.
def EmbDoc(value)
EmbDoc.new(value: value, location: Location.default)
Expand Down Expand Up @@ -478,8 +468,9 @@ def Ident(value)
end

# Create a new IfNode node.
def IfNode(predicate, statements, consequent)
def IfNode(keyword, predicate, statements, consequent)
IfNode.new(
keyword: keyword,
predicate: predicate,
statements: statements,
consequent: consequent,
Expand Down