Fix up rubocop violations

Author: kddnewton

.rubocop.yml

@@ -55,6 +55,9 @@ Style/IdenticalConditionalBranches:
 Style/IfInsideElse:
   Enabled: false
 
+Style/IfWithBooleanLiteralBranches:
+  Enabled: false
+
 Style/KeywordParametersOrder:
   Enabled: false
 

lib/syntax_tree.rb

@@ -23,7 +23,7 @@
 # We rely on Symbol#name being available, which is only available in Ruby 3.0+.
 # In case we're running on an older Ruby version, we polyfill it here.
 unless :+.respond_to?(:name)
-  class Symbol
+  class Symbol # rubocop:disable Style/Documentation
     def name
       to_s.freeze
     end

lib/syntax_tree/formatter.rb

@@ -148,7 +148,7 @@ def group
 
     # A similar version to the super, except that it calls back into the
     # separator proc with the instance of `self`.
-    def seplist(list, sep = nil, iter_method = :each) # :yield: element
+    def seplist(list, sep = nil, iter_method = :each)
       first = true
       list.__send__(iter_method) do |*v|
         if first

lib/syntax_tree/node.rb

@@ -621,11 +621,11 @@ def trailing_comma?
       return false unless arguments.is_a?(Args)
       parts = arguments.parts
 
-      if parts.last&.is_a?(ArgBlock)
+      if parts.last.is_a?(ArgBlock)
         # If the last argument is a block, then we can't put a trailing comma
         # after it without resulting in a syntax error.
         false
-      elsif parts.length == 1 && (part = parts.first) &&
+      elsif (parts.length == 1) && (part = parts.first) &&
             (part.is_a?(Command) || part.is_a?(CommandCall))
         # If the only argument is a command or command call, then a trailing
         # comma would be parsed as part of that expression instead of on this
@@ -891,6 +891,7 @@ def format(q)
     #
     # provided the line length was hit between `bar` and `baz`.
     class VarRefsFormatter
+      # The separator for the fill algorithm.
       class Separator
         def call(q)
           q.text(",")
@@ -2522,7 +2523,8 @@ def format_chain(q, children)
                 # https://github.com/prettier/plugin-ruby/issues/862.
               else
                 # If we're at a Call node and not a MethodAddBlock node in the
-                # chain then we're going to add a newline so it indents properly.
+                # chain then we're going to add a newline so it indents
+                # properly.
                 q.breakable_empty
               end
             end
@@ -2701,15 +2703,15 @@ def format(q)
       end
     end
 
+    # Print out the arguments to this call. If there are no arguments, then do
+    #nothing.
     def format_arguments(q)
       case arguments
       when ArgParen
         q.format(arguments)
       when Args
         q.text(" ")
         q.format(arguments)
-      else
-        # Do nothing if there are no arguments.
       end
     end
 
@@ -3180,6 +3182,8 @@ def format(q)
             end
           end
 
+        # Format the arguments for this command call here. If there are no
+        # arguments, then print nothing.
         if arguments
           parts = arguments.parts
 
@@ -3190,8 +3194,6 @@ def format(q)
             q.text(" ")
             q.nest(argument_alignment(q, doc)) { q.format(arguments) }
           end
-        else
-          # If there are no arguments, print nothing.
         end
       end
     end

lib/syntax_tree/parser.rb

@@ -1389,7 +1389,7 @@ def on_dot3(left, right)
     # :call-seq:
     #   on_dyna_symbol: (StringContent string_content) -> DynaSymbol
     def on_dyna_symbol(string_content)
-      if symbeg = find_token(SymBeg)
+      if (symbeg = find_token(SymBeg))
         # A normal dynamic symbol
         tokens.delete(symbeg)
         tstring_end = consume_tstring_end(symbeg.location)