Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: prometheus-community/postgres_exporter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: rs3000/postgres_exporter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4 commits
  • 13 files changed
  • 1 contributor

Commits on Sep 18, 2020

  1. Introduce histogram support

    Prior to this change, the custom queries were restricted to counters and
    gauges.
    
    This change introduces a new ColumnUsage, namely HISTOGRAM, that expects
    the column to contain an array of upper inclusive bounds for each
    observation bucket in the emitted metric.  It also expects three more
    columns to be present with the suffixes:
    - `_bucket`, containing an array of cumulative counters for the
      observation buckets;
    - `_sum`, the total sum of all observed values; and
    - `_count`, the count of events that have been observed.
    
    A flag has been added to the MetricMap struct to easily identify metrics
    that should emit a histogram and the construction of a histogram metric
    is aided by the pg.Array function and a new helper dbToUint64 function.
    
    Finally, and example of usage is given in queries.yaml.
    
    fixes #402
    
    Signed-off-by: Corin Lawson <corin@responsight.com>
    Corin Lawson committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    20d6bac View commit details
    Browse the repository at this point in the history
  2. Introduces tests for histogram support

    Prior to this change, the histogram support was untested.
    
    This change introduces a new integration test that reads a user query
    containing a number of histogram metrics.  Also, additional checks have
    been added to TestBooleanConversionToValueAndString to test dbToUint64.
    
    Signed-off-by: Corin Lawson <corin@responsight.com>
    Corin Lawson committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    1c4cc30 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2020

  1. Drop dependency on p2

    Prior to this change, the test-smoke script required the p2 binary to
    augment the Dockerfile under docker-postgres-replication.  I do not have
    that binary on my system, nor was I able to find an installer for it.
    The closest tool I found was p2cli, but even that did not work as
    expected.
    
    This change removes the Dockerfile.p2 file in favour of using Docker's
    builtin build args mechanism to augment the docker build.
    
    Signed-off-by: Corin Lawson <corin@responsight.com>
    Corin Lawson committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    c3162dc View commit details
    Browse the repository at this point in the history
  2. Prefer /usr/bin/env in shebang line

    Not all systems have /bin/bash available (mine among them).
    
    This change makes use of /usr/bin/env in place of /bin/bash.
    Corin Lawson committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    d3468e6 View commit details
    Browse the repository at this point in the history
Loading