Limit information about unintentionally covered units of code to class names and function names

Author: sebastianbergmann

.psalm/baseline.xml

@@ -2,7 +2,7 @@
 <files psalm-version="4.x-dev@">
   <file src="src/CodeCoverage.php">
     <ArgumentTypeCoercion occurrences="1">
-      <code>$unit[0]</code>
+      <code>$tmp[0]</code>
     </ArgumentTypeCoercion>
     <RedundantCondition occurrences="1">
       <code>is_array($linesToBeCovered)</code>

src/CodeCoverage.php

@@ -15,7 +15,6 @@
 use function array_keys;
 use function array_merge;
 use function array_unique;
-use function array_values;
 use function count;
 use function explode;
 use function is_array;
@@ -517,23 +516,23 @@ private function getAllowedLines(array $linesToBeCovered, array $linesToBeUsed):
     private function processUnintentionallyCoveredUnits(array $unintentionallyCoveredUnits): array
     {
         $unintentionallyCoveredUnits = array_unique($unintentionallyCoveredUnits);
-        sort($unintentionallyCoveredUnits);
+        $processed                   = [];
 
-        foreach (array_keys($unintentionallyCoveredUnits) as $k => $v) {
-            $unit = explode('::', $unintentionallyCoveredUnits[$k]);
+        foreach ($unintentionallyCoveredUnits as $unintentionallyCoveredUnit) {
+            $tmp = explode('::', $unintentionallyCoveredUnit);
+
+            if (count($tmp) !== 2) {
+                $processed[] = $unintentionallyCoveredUnit;
 
-            if (count($unit) !== 2) {
                 continue;
             }
 
             try {
-                $class = new ReflectionClass($unit[0]);
+                $class = new ReflectionClass($tmp[0]);
 
                 foreach ($this->parentClassesExcludedFromUnintentionallyCoveredCodeCheck as $parentClass) {
                     if ($class->isSubclassOf($parentClass)) {
-                        unset($unintentionallyCoveredUnits[$k]);
-
-                        break;
+                        continue 2;
                     }
                 }
             } catch (\ReflectionException $e) {
@@ -543,9 +542,15 @@ private function processUnintentionallyCoveredUnits(array $unintentionallyCovere
                     $e
                 );
             }
+
+            $processed[] = $tmp[0];
         }
 
-        return array_values($unintentionallyCoveredUnits);
+        $processed = array_unique($processed);
+
+        sort($processed);
+
+        return $processed;
     }
 
     private function analyser(): FileAnalyser