Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to use SCSS modules #13

Closed
benknight opened this issue Jul 31, 2018 · 4 comments
Closed

Make it possible to use SCSS modules #13

benknight opened this issue Jul 31, 2018 · 4 comments

Comments

@benknight
Copy link

I'm trying to use a pattern library in my CRA project that publishes React components that use CSS modules written with SCSS syntax with filenames ending with .module.scss.

It would be great if this fork could support that. Is it realistic?

@ro-savage
Copy link
Owner

This repo exactly replicates CRA v2.0's implementation of CSS Modules. If you wish to change it, you'll need to make an issue in CRA and have it approved. It'll then be ported to this repo.

@danoc
Copy link

danoc commented Aug 1, 2018

Hi @ro-savage,

Noticed that the CRA next branch supports SCSS modules:

https://github.com/facebook/create-react-app/blob/4a87838f527a00be6af42099546ff5d3adf63a6a/packages/react-scripts/config/webpack.config.dev.js#L39

I've tested it locally and confirmed that it works. It was added in facebook/create-react-app#4195.

I'd be happy to help with this.

@benknight
Copy link
Author

benknight commented Aug 1, 2018

Great thanks @danoc! Sounds like these most recent updates then can just be ported over.

@benknight
Copy link
Author

@ro-savage do you think we could re-open this issue considering the above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants