Skip to content

Rescript 9.1.1 update needed #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dusty-phillips opened this issue Apr 17, 2021 · 4 comments
Closed

Rescript 9.1.1 update needed #34

dusty-phillips opened this issue Apr 17, 2021 · 4 comments

Comments

@dusty-phillips
Copy link

I'm playing with the Rescript 9.1.1 beta and getting a "Cannot find a nearby node_modules/bs-platform/darwin/bsc.exe. It's needed for formatting." error. I assume this is because the binaries have been moving around.

@r17x
Copy link

r17x commented Apr 18, 2021

@dusty-phillips alternative solution

git clone https://github.com/rescript-lang/rescript-vscode ~/rescript-vscode
cd rescript-vscode
npm install
npm run compile 

Then, modify your lang-server for rescript. I'm using nvim-coc (coc-settings.json)

"languageserver": {
...
    "rescript": {
      "enable": true,
      "module": "~/rescript-vscode/server/out/server.js",
      "args": ["--node-ipc"],
      "filetypes": ["rescript"],
      "rootPatterns": ["bsconfig.json"]
    },
...
}

anyway this solution like #20 (comment)

@dusty-phillips
Copy link
Author

That works! I'll leave the issue open, since I assume vim-rescript will want to update it internally as well.

@ryyppy
Copy link
Member

ryyppy commented Apr 20, 2021

We also need to make sure that the plain vim functionality detects the package correctly. Fortunately we already got #35 going. Will review this and release a new version later today / tomorrow.

@ryyppy
Copy link
Member

ryyppy commented May 5, 2021

Done.

@ryyppy ryyppy closed this as completed May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants