vim-rescript change current directory even it's not rescript project

[wingyplus]

I found this bug when I working on another project (such as Go or Elixir). The current working directory was change caused by vim-rescript. The fzf plugin affected also.

I guess that it's because of this line https://github.com/rescript-lang/vim-rescript/blob/master/autoload/rescript.vim#L51. Maybe it should not called lcd when it cannot detect rescript project.

[wingyplus]

Oh, it's seems dup with #23 ?

[ryyppy]

are you sure this is actually caused by our plugin? The autocommand for updating the environment only triggers when you create / open a new .res, .resi file: https://github.com/rescript-lang/vim-rescript/blob/master/ftplugin/rescript.vim#L17

[amiralies]

I can confirm this happens for me too. I.e opening a monorepo which contains only scala code.

[ryyppy]

@amiralies @wingyplus can you please follow the install instructions of #32 and check if this fixes your issue?

[amiralies]

not heavily tested but works as expected for me 👍

[Dkendal]

Can confirm that this happens to me as well, regardless of where I am in the filesystem

[ryyppy]

@Dkendal can you try the fix posted above and check if it solves the issue on your machine? If I get some more confirmations that this fix works reliably, I will probably just merge and tag a release

[Dkendal]

@ryyppy looks like it works!