Skip to content

Commit c2db765

Browse files
committed
initial commit
0 parents  commit c2db765

File tree

3 files changed

+158
-0
lines changed

3 files changed

+158
-0
lines changed

Diff for: 0000-template.md

+70
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,70 @@
1+
---
2+
Feature Name: (fill me in with a unique ident, `my_awesome_feature`)
3+
Start Date: (fill me in with today's date, YYYY-MM-DD)
4+
RFC PR: (leave this empty)
5+
ReScript Issue: (leave this empty)
6+
---
7+
8+
# Summary
9+
10+
Brief explanation of the feature.
11+
12+
# Motivation
13+
14+
Why are we doing this? What use cases does it support? What is the expected outcome?
15+
16+
Please focus on explaining the motivation so that if this RFC is not accepted, the motivation could be used to develop alternative solutions. In other words, enumerate the constraints you are trying to solve without coupling them too closely to the solution you have in mind.
17+
18+
# Detailed design
19+
20+
This is the bulk of the RFC. Explain the design in enough detail for somebody familiar with ReScript to understand, and for somebody familiar with the implementation to implement. This should get into specifics and corner-cases, and include examples of how the feature is used. Any new terminology should be defined here.
21+
22+
# Drawbacks
23+
24+
Why should we not do this? Please consider:
25+
26+
- implementation cost, both in term of code size and complexity
27+
- whether the proposed feature can be implemented in user space
28+
- the impact on teaching people ReScript
29+
- integration of this feature with other existing and planned features
30+
- cost of migrating existing ReScript codebase (is it a breaking change?)
31+
32+
There are tradeoffs to choosing any path. Attempt to identify them here.
33+
34+
# Rationale and alternatives
35+
36+
- Why is this design the best in the space of possible designs?
37+
- What other designs have been considered and what is the rationale for not choosing them?
38+
- What is the impact of not doing this?
39+
- If this is a language proposal, could this be done in a library instead?
40+
41+
# Prior art
42+
43+
Discuss prior art, both the good and the bad, in relation to this proposal. A few examples of what this can include are:
44+
45+
- For language, library, tools, and compiler proposals: Does this feature exist in other programming languages and what experience has their community had?
46+
- For community proposals: Is this done by some other community and what were their experiences with it?
47+
- For other teams: What lessons can we learn from what other communities have done here?
48+
- Papers: Are there any published papers or great posts that discuss this? If you have some relevant papers to refer to, this can serve as a more detailed theoretical background.
49+
50+
This section is intended to encourage you as an author to think about the lessons from other languages and provide readers of your RFC with a fuller picture. If there is no prior art, that is fine - your ideas are interesting to us whether they are brand new or if it is an adaptation from other languages.
51+
52+
Note that while precedent set by other languages is some motivation, it does not on its own motivate an RFC.
53+
54+
# Adoption strategy
55+
56+
If we implement this proposal, how will existing ReScript developers adopt it? Is this a breaking change? What is the migration plan? Should we coordinate with other projects or libraries?
57+
58+
# Unresolved questions
59+
60+
Optional, but suggested for first drafts. What parts of the design are still TBD?
61+
62+
# Future posibilities
63+
64+
Think about what the natural extension and evolution of your proposal would be and how it would affect the language and project as a whole in a holistic way. Try to use this section as a tool to more fully consider all possible interactions with the project and language in your proposal.
65+
66+
This is also a good place to "dump ideas", if they are out of scope for the RFC you are writing but otherwise related.
67+
68+
If you have tried and cannot think of any future possibilities, you may simply state that you cannot think of anything.
69+
70+
Note that having something written down in the future-possibilities section is not a reason to accept the current or a future RFC; such notes should be in the section on motivation or rationale in this or subsequent RFCs. The section merely provides additional information.

Diff for: LICENSE

+19
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
MIT License
2+
3+
Copyright (c) 2024 - Authors of ReScript
4+
5+
Permission is hereby granted, free of charge, to any person obtaining a copy
6+
of this software and associated documentation files (the "Software"), to deal
7+
in the Software without restriction, including without limitation the rights
8+
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
9+
copies of the Software, and to permit persons to whom the Software is
10+
furnished to do so, subject to the following conditions:
11+
The above copyright notice and this permission notice shall be included in all
12+
copies or substantial portions of the Software.
13+
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
14+
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
15+
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
16+
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
17+
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
18+
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
19+
SOFTWARE.

Diff for: README.md

+69
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,69 @@
1+
# ReScript RFCs
2+
3+
The "RFC" (request for comments) process is intended to provide a consistent and controlled path for new features to enter the project.
4+
5+
Many changes, including bug fixes and documentation improvements can be implemented and reviewed via the normal GitHub pull request workflow.
6+
7+
Some changes though are "substantial", and we ask that these be put through a bit of a design process and produce a consensus among the ReScript core team.
8+
9+
## When to follow this process
10+
11+
You should consider using this process if you intend to make "substantial" changes to ReScript or its documentation. Some examples that would benefit from an RFC are:
12+
13+
- Any semantic or syntactic change to the language that is not a bugfix.
14+
- Removing language features, including those that are feature-gated.
15+
- The introduction of new toolchain that brings about a significant change in the ReScript experience. (e.g. GenType, Reanalyze)
16+
17+
Some changes do not require an RFC:
18+
19+
- Rephrasing, reorganizing, refactoring, or otherwise "changing shape does not change meaning".
20+
- Additions that strictly improve objective, numerical quality criteria (warning removal, speedup, better platform coverage, more parallelism, trap more errors, etc.)
21+
- Additions only likely to be noticed by other developers-of-rescript, invisible to users-of-rescript.
22+
23+
## Before creating an RFC
24+
25+
A hastily-proposed RFC can hurt its chances of acceptance. Low quality proposals, proposals for previously-rejected features, or those that don't fit into the near-term roadmap, may be quickly rejected, which can be demotivating for the unprepared contributor. Laying some groundwork ahead of the RFC can make the process smoother.
26+
27+
Although there is no single way to prepare for submitting an RFC, it is generally a good idea to pursue feedback from other project developers beforehand, to ascertain that the RFC may be desirable; having a consistent impact on the project requires concerted effort toward consensus-building.
28+
29+
The most common preparations for writing and submitting an RFC include talking the idea over on the official [forum](https://forum.rescript-lang.org/). You may file issues on this repo for discussion.
30+
31+
As a rule of thumb, receiving encouraging feedback from long-standing project developers, and particularly members of the relevant core team is a good indication that the RFC is worth pursuing.
32+
33+
## What the process is
34+
35+
- Fork the RFC repo https://github.com/rescript-lang/rfcs
36+
- Copy `0000-template.md` to `text/0000-my-feature.md` (where 'my-feature' is descriptive. Don't assign an RFC number yet).
37+
- Fill in the RFC. Put care into the details: **RFCs that do not present convincing motivation, demonstrate understanding of the impact of the design, or are disingenuous about the drawbacks or alternatives tend to be poorly-received.**
38+
- Submit a pull request. As a pull request the RFC will receive design feedback from the larger community, and the author should be prepared to revise it in response.
39+
- Now that your RFC has an open pull request, use the issue number of the PR to rename the file: update your `0000-` prefix to that number. Also update the "RFC PR" link at the top of the file.
40+
- Build consensus and integrate feedback. RFCs that have broad support are much more likely to make progress than those that don't receive any comments.
41+
- Eventually, the team will decide whether the RFC is a candidate for inclusion in ReScript. Note that the team review may take a long time, and we suggest that you ask members of the community to review it first.
42+
- RFCs that are candidates for inclusion in ReScript will enter a "final comment period" 7 calendar days. The beginning of this period will be signaled with a comment and tag on the RFC's pull request.
43+
- An RFC can be modified based upon feedback from the team and community. Significant modifications may trigger a new final comment period.
44+
- An RFC may be rejected by the team after public discussion has settled and comments have been made summarizing the rationale for rejection. A member of the team should then close the RFCs associated pull request.
45+
- An RFC may be accepted at the close of its final comment period. A team member will merge the RFCs associated pull request, at which point the RFC will become 'active'.
46+
47+
## The RFC lifecycle
48+
49+
Once an RFC becomes active, then authors may implement it and submit the feature as a pull request to the ReScript repo. Becoming 'active' is not a rubber stamp, and in particular still does not mean the feature will ultimately be merged; it does mean that the core team has agreed to it in principle and are amenable to merging it.
50+
51+
Furthermore, the fact that a given RFC has been accepted and is 'active' implies nothing about what priority is assigned to its implementation, nor whether anybody is currently working on it.
52+
53+
Modifications to active RFCs can be done in followup PRs. We strive to write each RFC in a manner that it will reflect the final design of the feature; but the nature of the process means that we cannot expect every merged RFC to actually reflect what the end result will be at the time of the next major release; therefore we try to keep each RFC document somewhat in sync with the language feature as planned, tracking such changes via followup pull requests to the document.
54+
55+
## Implementing an RFC
56+
57+
The author of an RFC is not obligated to implement it. Of course, the RFC author (like any other developer) is welcome to post an implementation for review after the RFC has been accepted.
58+
59+
If you are interested in working on the implementation for an 'active' RFC, but cannot determine if someone else is already working on it, feel free to ask (e.g. by leaving a comment on the associated issue).
60+
61+
## Reviewing RFCs
62+
63+
Currently, the ReScript team cannot commit to reviewing RFCs in a timely manner. When you submit an RFC, your primary goal should be to solicit community feedback and generate a rich discussion. The ReScript team will attempt to review some set of open RFC pull requests as often as possible.
64+
65+
We try to make sure that any RFC that we accept is accepted at the monthly team meeting, and reported in core team notes. Every accepted feature should have a core team champion, who will represent the feature and its progress.
66+
67+
## Inspiration
68+
69+
ReScript's RFC process owes its inspiration to the RFC process adopted by [Rust](https://github.com/rust-lang/rfcs), [Yarn](https://github.com/yarnpkg/rfcs), [React](https://github.com/reactjs/rfcs), and the [Ember](https://github.com/emberjs/rfcs).

0 commit comments

Comments
 (0)