From 0b04268cc7aceb143c5595c0946ec4bdce18aa76 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Paul=20Tsnobiladz=C3=A9?= Date: Thu, 6 Feb 2025 09:45:14 +0100 Subject: [PATCH] remove ignore in res_scanner --- CHANGELOG.md | 4 ++++ compiler/syntax/src/res_scanner.ml | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c3917f4045..1aff3db4f6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -22,6 +22,10 @@ - Fix `%external` extension. https://github.com/rescript-lang/rescript/pull/7272 - Fix issue with type environment for unified ops. https://github.com/rescript-lang/rescript/pull/7277 +#### :house: Internal + +- Remove ignore in res_scanner.ml . https://github.com/rescript-lang/rescript/pull/7280 + # 12.0.0-alpha.8 #### :bug: Bug fix diff --git a/compiler/syntax/src/res_scanner.ml b/compiler/syntax/src/res_scanner.ml index 613d273d6c..3803d2d132 100644 --- a/compiler/syntax/src/res_scanner.ml +++ b/compiler/syntax/src/res_scanner.ml @@ -257,13 +257,13 @@ let scan_number scanner = 8) | _ -> 10 in - ignore (scan_digits scanner ~base); + let _ : bool = scan_digits scanner ~base in (* *) let is_float = if '.' == scanner.ch then ( next scanner; - ignore (scan_digits scanner ~base); + let _ : bool = scan_digits scanner ~base in true) else false in