Bug: Not possible to use default value for renamed props in JSX 4

[DZakh]

https://rescript-lang.org/try?version=v10.1.2&code=ALBWGcA8GEHsDsBmBLA5gCgN4DcCmAncZBALgAIBmAXwEoAoOgW1gBMBXAG1zIEkAXXIzIBeMpjpkywfLgCGAYz4A6ebEYAHBLnh8JZLnzKNZAa26j0APxbJwsgEZcWZWeDK48+AJ58AFsnhUABFbBydye1hYDmFEWQ5wXBoRAD4xPUkAJTlFJXA+fACMDwIff0CQu0dcZwB+MgAiArZcBrJyBriE1vpJKjp+uhAIGAQUDBwCIlIyABZaBmZ2Ll4BRgAmEXTJaRzlVQ0tHT0DI1NzMisbKqcXNxLvPyLKsJqIqJiuxOThNPFJLJ7PIFIroB5lZ6hap1RrNVrtRpfHp6fr9IA

[mununki]

Good catch!

module C3 = {
  type props<'disabled> = {disabled?: 'disabled}

  let make = ({disabled: ?everythingDisabled, _}: props<bool>) => {
    let disabled = switch disabled { // should use everythingDisabled
    | Some(disabled) => disabled
    | None => false
    }

    {
      React.string(everythingDisabled ? "true" : "false")
    }
  }
  ...
}

[mununki]

This seems fine to me. I think this could be fixed at the same time with issue #6374.
What do you think?

module C3 = {
  type props<'disabled> = {disabled?: 'disabled}

  let make = ({disabled: ?everythingDisabled_, _}: props<bool>) => { // rename alias *_
    let everythingDisabled = switch everythingDisabled_ { // refer to it here
    | Some(everythingDisabled) => everythingDisabled
    | None => false
    }

    {
      React.string(everythingDisabled ? "true" : "false")
    }
  }
  ...
}

[mununki]

As you suggested:

module C3 = {
  type props<'disabled> = {disabled?: 'disabled}

  let make = (props: props<bool>) => {
    let everythingDisabled = switch props {
    | {disabled} => disabled
    | _ => false
    }

    {
      React.string(everythingDisabled ? "true" : "false")
    }
  }
  ...
}

What do you think?

[mununki]

Ah, I'm afraid of the case when we have other props along with disabled. Destructuring would be better for that case.