Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: @as doesn't work for props with jsx V3 #6373

Closed
DZakh opened this issue Aug 28, 2023 · 4 comments
Closed

Bug: @as doesn't work for props with jsx V3 #6373

DZakh opened this issue Aug 28, 2023 · 4 comments
Labels
stale Old issues that went stale

Comments

@DZakh
Copy link
Contributor

DZakh commented Aug 28, 2023

https://rescript-lang.org/try?version=v10.1.2&code=ALBWGcA8GEHsDsBmBLA5gCgN4DcCmAncZBALgAIBmAXwEoAoOgW1gBMBXAG1zIEklYAguDIBeMpjpkywZuy7oARMADGAQ3wdVAekQdY+VQprT8uVcoAuAOmWxGABwS54FyWVyQLBeKo5lGqgDWuOTowKrgihYAnva4RmQAfjFxAPrk4Bb4yPCoxiIAfGQASmaWVrhcjM4WomQKfIiwCnRUTKyc3I2wALKquVwsdRJSMh3ySmoa2rr6hsbApubWtg5OLm4eXvg+fgHBoYmpKSFkmdm5+UWlyxVVNXUN-C1tdFy1lXUAPN19A7hDY6xXAiBRNZpkLQFN64D4cABM326QjIJ1SoPBCkh0KAA

Related to:
#5908

And after the #6354 is released, it might become a bigger problem.

Now, we need to migrate to JSX V4 before we can start using ReScript V11 🥲 It was needed anyways, but I wanted to do it in a different order.

@DZakh
Copy link
Contributor Author

DZakh commented Sep 6, 2023

@zth I've encountered another issue caused by the removed key mangling in rescript-relay that disallowed fields that stopped working. And since @as doesn't work with external, there's no workaround (without the need of breaking changes).
So, I think we either should revert key mangling for now, which I really don't want to do. Or add @as support for external and update the affected libs.

@zth
Copy link
Collaborator

zth commented Sep 6, 2023

@DZakh maybe better to open a dedicated issue for this on the RescriptRelay tracker. V3 removes object makers anyway.

Copy link

github-actions bot commented Sep 2, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Old issues that went stale label Sep 2, 2024
@zth zth closed this as completed Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Old issues that went stale
Projects
None yet
Development

No branches or pull requests

2 participants