Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error if the missing -bs-super-error flag is in a dependent package #6242

Closed
mununki opened this issue May 4, 2023 · 4 comments · Fixed by #6243
Closed

Build error if the missing -bs-super-error flag is in a dependent package #6242

mununki opened this issue May 4, 2023 · 4 comments · Fixed by #6243
Assignees

Comments

@mununki
Copy link
Member

mununki commented May 4, 2023

When we cleaned up super-error, we removed the compiler's -bs-super-error flag, but I ran into an issue where it wouldn't build if a dependent package used that flag. I was wondering if we could bring it back and deprecate it first.

FAILED: src/ReForm.ast
unknown option: '-bs-super-errors'.
Usage: bsc <options> <files>
Options are:
Options:
  -w                        <list>  Enable or disable warnings according to <list>:
                            +<spec>   enable warnings in <spec>
                            -<spec>   disable warnings in <spec>
                            @<spec>   enable warnings in <spec> and treat them as errors
                            <spec> can be:
                            <num>             a single warning number
                            <num1>..<num2>    a range of consecutive warning numbers
                            default setting is +a-4-9-20-40-41-42-50-61-102
  -bs-g                     Debug mode
  -bs-D                     Define conditional variable e.g, -D DEBUG=true
  -e                        (experimental) set the string to be evaluated in ReScript syntax
  -v                        Print compiler version and location of standard library and exit
  -version                  Print version and exit
  -warn-help                Show description of warning numbers
  -warn-error               <list>  Enable or disable error status for warnings according
                            to <list>.  See option -w for the syntax of <list>.
                            Default setting is -a+5+6+101+109

FAILED: cannot make progress due to previous errors.
@cristianoc
Copy link
Collaborator

CC @cknitt

@cknitt
Copy link
Member

cknitt commented May 4, 2023

Hmm, yes, there are probably a lot of libs out there that still have this flag set. Deprecating instead of removing sounds good to me.

I'll wait with the alpha.6 release for this then.

@mununki
Copy link
Member Author

mununki commented May 4, 2023

I'll fix it soon.

@mununki
Copy link
Member Author

mununki commented May 4, 2023

@cknitt #6243 PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants