Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spring cleaning: super errors #6202

Closed
cristianoc opened this issue Apr 26, 2023 · 2 comments · Fixed by #6199
Closed

Spring cleaning: super errors #6202

cristianoc opened this issue Apr 26, 2023 · 2 comments · Fixed by #6199
Assignees
@mununki
Labels
help wanted
Milestone
v12

Comments

@cristianoc
Copy link
Collaborator

Super errors was created at a time when the compiler had 2 functions: both an OCaml compiler and a ReScript compiler.
Since now it is only the latter, super errors can be cleaned up. Should not be in a different part of the code base than "normal" error handling, and partially replace some cases. Every error message should be "super".
@cristianoc cristianoc added this to the v12 milestone Apr 26, 2023
@cristianoc
Copy link
Collaborator Author

Related: #6203

@cristianoc cristianoc mentioned this issue Apr 26, 2023
Merged
@cristianoc
Copy link
Collaborator Author

#5889

@cristianoc cristianoc mentioned this issue Apr 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mununki mununki

Labels
help wanted
Projects
None yet
Milestone
v12
Development

Successfully merging a pull request may close this issue.

Clean up Super_error rescript-lang/rescript
2 participants
@cristianoc @mununki