Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jsx mode is ignored when set via @@jsxConfig #5927

Closed
cknitt opened this issue Jan 5, 2023 · 0 comments · Fixed by #5929
Closed

Jsx mode is ignored when set via @@jsxConfig #5927

cknitt opened this issue Jan 5, 2023 · 0 comments · Fixed by #5929
Assignees
@cknitt

Comments

@cknitt
Copy link
Member

cknitt commented Jan 5, 2023

When setting the JSX mode in-source via

@@jsxConfig({version: 4, mode: "automatic"})

it is currently ignored. This is because the AST is

Pexp_constant PConst_string ("automatic",Some "js")

but the code is matching for

{pexp_desc = Pexp_constant (Pconst_string (value, None))}

This problem exists for both 10.1.x and master.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cknitt cknitt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix jsx mode being ignored when set via @@jsxConfig cknitt/rescript
1 participant
@cknitt