Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up super_errors duplications #5879

Closed
cknitt opened this issue Dec 7, 2022 · 1 comment · Fixed by #6246
Closed

Clean up super_errors duplications #5879

cknitt opened this issue Dec 7, 2022 · 1 comment · Fixed by #6246

Comments

@cknitt
Copy link
Member

cknitt commented Dec 7, 2022

jscomp/super_errors/super_code_frame.ml and jscomp/super_errors/super_location.ml are currently duplicated into res_syntax/src/res_diagnostics_printing_utils.ml.

This can be cleaned up after #5876.

@ryyppy
Copy link
Member

ryyppy commented Dec 10, 2022

This can be cleaned up after #5876

What does "clean up" mean?

If I am not mistaken, the res_diagnostics_printing_utils.ml is the more up-to-date version of the diagnostics printer, so one would need to replace the newest logic in jscomp/super_errors/super_location.ml, then remove the original res_diagnostics module and replace it with the super_location? Or should it be the other way round due to submodule relations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants