Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uncurried external make for JSX V4 #5811

Closed
mununki opened this issue Nov 16, 2022 · 0 comments · Fixed by #5812
Closed

Fix uncurried external make for JSX V4 #5811

mununki opened this issue Nov 16, 2022 · 0 comments · Fixed by #5812

Comments

@mununki
Copy link
Member

mununki commented Nov 16, 2022

module E = {
  @react.component
  external make: (~x: string) => React.element = "default"
}

module EUncurried = {
  @react.component
  external make: (. ~x: string) => React.element = "default"
}

transformed to

module E = {
  type props<'x> = {
    x: 'x,
  }

  external make: React.componentLike<props<string>, React.element> = "default"
}

module EUncurried = {
  type props = {}

  external make: React.componentLike<props, (. ~x: string) => React.element> = "default"
}

The both outputs are expected to be same, but not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant