Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git commit hash to bs_version.ml #4577

Closed
ryyppy opened this issue Jul 29, 2020 · 2 comments
Closed

Add git commit hash to bs_version.ml #4577

ryyppy opened this issue Jul 29, 2020 · 2 comments

Comments

@ryyppy
Copy link
Member

ryyppy commented Jul 29, 2020

I am regularly building BuckleScript JS bundles out of non-tagged revisions of BuckleScript and it's hard to keep track on what exact BS code the bundle is based on.

Is it possible to extend the build_version.js script in a way that generated following (extended) bs_version.ml file?
I'd expect a module something like this:

let version = "8.2.0"
let header = 
   "// Generated by BUCKLESCRIPT, PLEASE EDIT WITH CARE"  
let package_name = "bs-platform"   

let git_commit = "123456"

That way we can easily provide full version info in the playground and render a direct link to the exact commit as well

@bobzhang
Copy link
Member

it should be doable, the only concern is that it would create too much noise. imagine that you have such diff every commit

@ryyppy
Copy link
Member Author

ryyppy commented Aug 4, 2020

Found a solution that doesn't involve any diffs / build system changes. This will be fixed by #4518

@ryyppy ryyppy closed this as completed Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants