improve the pattern match code generation

Author: bobzhang

jscomp/test/complex_if_test.js

@@ -16,22 +16,21 @@ function escaped(s) {
   var n = 0;
   for(var i = 0 ,i_finish = s.length; i < i_finish; ++i){
     var match = s[i];
-    var tmp;
-    if (match >= 32) {
-      var switcher = match - 34 | 0;
-      tmp = switcher > 58 || switcher < 0 ? (
-          switcher >= 93 ? 4 : 1
+    n = n + (
+      match >= 32 ? (
+          match > 92 || match < 34 ? (
+              match >= 127 ? 4 : 1
+            ) : (
+              match > 91 || match < 35 ? 2 : 1
+            )
         ) : (
-          switcher > 57 || switcher < 1 ? 2 : 1
-        );
-    } else {
-      tmp = match >= 11 ? (
-          match !== 13 ? 4 : 2
-        ) : (
-          match >= 8 ? 2 : 4
-        );
-    }
-    n = n + tmp | 0;
+          match >= 11 ? (
+              match !== 13 ? 4 : 2
+            ) : (
+              match >= 8 ? 2 : 4
+            )
+        )
+    ) | 0;
   }
   if (n === s.length) {
     return Bytes.copy(s);

jscomp/test/ext_bytes_test.js

@@ -25,22 +25,21 @@ function escaped(s) {
   var n = 0;
   for(var i = 0 ,i_finish = s.length; i < i_finish; ++i){
     var match = s[i];
-    var tmp;
-    if (match >= 32) {
-      var switcher = match - 34 | 0;
-      tmp = switcher > 58 || switcher < 0 ? (
-          switcher >= 93 ? 4 : 1
+    n = n + (
+      match >= 32 ? (
+          match > 92 || match < 34 ? (
+              match >= 127 ? 4 : 1
+            ) : (
+              match > 91 || match < 35 ? 2 : 1
+            )
         ) : (
-          switcher > 57 || switcher < 1 ? 2 : 1
-        );
-    } else {
-      tmp = match >= 11 ? (
-          match !== 13 ? 4 : 2
-        ) : (
-          match >= 8 ? 2 : 4
-        );
-    }
-    n = n + tmp | 0;
+          match >= 11 ? (
+              match !== 13 ? 4 : 2
+            ) : (
+              match >= 8 ? 2 : 4
+            )
+        )
+    ) | 0;
   }
   if (n === s.length) {
     return Bytes.copy(s);

jscomp/test/ext_string_test.js

@@ -179,15 +179,14 @@ function escaped(s) {
       if (match < 32) {
         return true;
       }
-      var switcher = match - 34 | 0;
-      if (switcher > 58 || switcher < 0) {
-        if (switcher >= 93) {
+      if (match > 92 || match < 34) {
+        if (match >= 127) {
           return true;
         }
         _i = i + 1 | 0;
         continue ;
       }
-      if (switcher > 57 || switcher < 1) {
+      if (match > 91 || match < 35) {
         return true;
       }
       _i = i + 1 | 0;
@@ -467,18 +466,16 @@ function is_valid_module_file(s) {
     return false;
   }
   return unsafe_for_all_range(s, 1, len - 1 | 0, (function (x) {
-                if (x < 65) {
-                  if (x >= 48) {
-                    return x < 58;
+                if (x >= 65) {
+                  if (x > 96 || x < 91) {
+                    return x < 123;
                   } else {
-                    return x === 39;
+                    return x === 95;
                   }
-                }
-                var switcher = x - 91 | 0;
-                if (switcher > 5 || switcher < 0) {
-                  return switcher < 32;
+                } else if (x >= 48) {
+                  return x < 58;
                 } else {
-                  return switcher === 4;
+                  return x === 39;
                 }
               }));
 }