Merge pull request #2196 from BuckleScript/fix_2179

fix #2179 warning for polymoprhic comparison

Author: bobzhang

jscomp/bin/whole_compiler.ml

@@ -96266,19 +96266,22 @@ let translate loc (prim_name : string)
     | _ -> assert false
     end
   | "caml_obj_truncate"
-  | "caml_lazy_make_forward"
-  | "caml_compare"
+  | "caml_lazy_make_forward"  
   | "caml_int_compare"
   | "caml_int32_compare"
   | "caml_nativeint_compare"
+    -> 
+    call Js_runtime_modules.obj_runtime
+  | "caml_compare"
   | "caml_equal"
   | "caml_notequal"
   | "caml_greaterequal"
   | "caml_greaterthan"
   | "caml_lessequal"
   | "caml_lessthan"
-
     -> 
+    if Warnings.is_active Warnings.Bs_polymorphic_comparison then 
+      Location.prerr_warning loc Warnings.Bs_polymorphic_comparison ; 
     call Js_runtime_modules.obj_runtime
   | "caml_obj_set_tag" 
     -> begin match args with 

jscomp/core/lam_dispatch_primitive.ml

@@ -568,19 +568,22 @@ let translate loc (prim_name : string)
     | _ -> assert false
     end
   | "caml_obj_truncate"
-  | "caml_lazy_make_forward"
-  | "caml_compare"
+  | "caml_lazy_make_forward"  
   | "caml_int_compare"
   | "caml_int32_compare"
   | "caml_nativeint_compare"
+    -> 
+    call Js_runtime_modules.obj_runtime
+  | "caml_compare"
   | "caml_equal"
   | "caml_notequal"
   | "caml_greaterequal"
   | "caml_greaterthan"
   | "caml_lessequal"
   | "caml_lessthan"
-
     -> 
+    if Warnings.is_active Warnings.Bs_polymorphic_comparison then 
+      Location.prerr_warning loc Warnings.Bs_polymorphic_comparison ; 
     call Js_runtime_modules.obj_runtime
   | "caml_obj_set_tag" 
     -> begin match args with 

jscomp/stdlib/Makefile.shared

@@ -32,7 +32,7 @@ include ../Makefile.shared
 # endif
 
 BS_FLAGS= $(BS_COMMON_FLAGS) $(BS_PKG_FLAGS) 
-COMPFLAGS= $(BS_FLAGS) -strict-sequence -w +33..39 -g -warn-error A  -nostdlib \
+COMPFLAGS= $(BS_FLAGS) -strict-sequence -w +33..39 -g  -nostdlib \
           -safe-string -I ../runtime $(PROD_BS_FLAGS)
 
 

jscomp/test/Makefile

@@ -213,7 +213,7 @@ $(addsuffix .cmi, $(OTHERS)): ../runtime/js.cmi
 $(addsuffix .cmj, $(OTHERS)): ../runtime/js.cmj
 
 # It is okay to test deprecated API
-COMPFLAGS+=  $(MODULE_FLAGS) -w -40 -warn-error A+8-3-30-26-101 
+COMPFLAGS+=  $(MODULE_FLAGS) -w -40 -warn-error A+8-3-30-26-101-102 
 COMPFLAGS+=  -bs-no-version-header -absname -bs-diagnose -bs-cross-module-opt -bs-package-name  bs-platform -bs-package-output commonjs:jscomp/test