remove legacy foward_tag

Author: bobzhang

jscomp/runtime/caml_js_exceptions.ml

@@ -6,13 +6,7 @@ type  t =
 exception Error of  t 
 
 
-(**
-   {[
-     exception A of int;;
-     let v = A  3 ;;
-     Obj.tag (Obj.field (Obj.repr v) 0);;
-     - : int = 248
-   ]}
+(**   
    This function has to be in this module Since 
    [Error] is defined here 
 *)

jscomp/runtime/caml_obj.ml

@@ -297,14 +297,7 @@ let rec caml_equal (a : Obj.t) (b : Obj.t) : bool =
         (* [a] [b] could not be null, so it can not raise *)
         let tag_a = Obj.tag a in
         let tag_b = Obj.tag b in
-        (* double_array_tag: 254
-           forward_tag:250
-        *)
-        if tag_a = 250 then
-          caml_equal (Obj.field a 0) b
-        else if tag_b = 250 then
-          caml_equal a (Obj.field b 0)
-        else if tag_a = 248 (* object/exception *)  then
+        if tag_a = 248 (* object/exception *)  then
           (Obj.magic  (Obj.field a 1)) ==  (Obj.magic (Obj.field b 1 ))
         else if tag_a = 251 (* abstract_tag *) then
           raise (Invalid_argument "equal: abstract value")

lib/es6/caml_obj.js

@@ -255,104 +255,88 @@ function caml_compare(a, b) {
   }
 }
 
-function caml_equal(_a, _b) {
-  while(true) {
-    var b = _b;
-    var a = _a;
-    if (a === b) {
-      return true;
-    }
-    var a_type = typeof a;
-    if (a_type === "string" || a_type === "number" || a_type === "boolean" || a_type === "undefined" || a === null) {
-      return false;
-    }
-    var b_type = typeof b;
-    if (a_type === "function" || b_type === "function") {
-      throw {
-            RE_EXN_ID: "Invalid_argument",
-            _1: "equal: functional value",
-            Error: new Error()
-          };
-    }
-    if (b_type === "number" || b_type === "undefined" || b === null) {
-      return false;
-    }
-    var tag_a = a.tag | 0;
-    var tag_b = b.tag | 0;
-    if (tag_a === 250) {
-      _a = a[0];
-      continue ;
-    }
-    if (tag_b === 250) {
-      _b = b[0];
-      continue ;
-    }
-    if (tag_a === 248) {
-      return a[1] === b[1];
-    }
-    if (tag_a === 251) {
-      throw {
-            RE_EXN_ID: "Invalid_argument",
-            _1: "equal: abstract value",
-            Error: new Error()
-          };
-    }
-    if (tag_a !== tag_b) {
-      return false;
-    }
-    if (tag_a === 256) {
-      return a[1] === b[1];
-    }
-    var len_a = a.length | 0;
-    var len_b = b.length | 0;
-    if (len_a === len_b) {
-      if (Array.isArray(a)) {
-        var _i = 0;
-        while(true) {
-          var i = _i;
-          if (i === len_a) {
-            return true;
-          }
-          if (!caml_equal(a[i], b[i])) {
-            return false;
-          }
-          _i = i + 1 | 0;
-          continue ;
+function caml_equal(a, b) {
+  if (a === b) {
+    return true;
+  }
+  var a_type = typeof a;
+  if (a_type === "string" || a_type === "number" || a_type === "boolean" || a_type === "undefined" || a === null) {
+    return false;
+  }
+  var b_type = typeof b;
+  if (a_type === "function" || b_type === "function") {
+    throw {
+          RE_EXN_ID: "Invalid_argument",
+          _1: "equal: functional value",
+          Error: new Error()
         };
-      } else if ((a instanceof Date && b instanceof Date)) {
-        return !(a > b || a < b);
-      } else {
-        var result = {
-          contents: true
+  }
+  if (b_type === "number" || b_type === "undefined" || b === null) {
+    return false;
+  }
+  var tag_a = a.tag | 0;
+  var tag_b = b.tag | 0;
+  if (tag_a === 248) {
+    return a[1] === b[1];
+  }
+  if (tag_a === 251) {
+    throw {
+          RE_EXN_ID: "Invalid_argument",
+          _1: "equal: abstract value",
+          Error: new Error()
         };
-        var do_key_a = (function(b,result){
-        return function do_key_a(key) {
-          if (!b.hasOwnProperty(key)) {
-            result.contents = false;
-            return ;
-          }
-          
+  }
+  if (tag_a !== tag_b) {
+    return false;
+  }
+  if (tag_a === 256) {
+    return a[1] === b[1];
+  }
+  var len_a = a.length | 0;
+  var len_b = b.length | 0;
+  if (len_a === len_b) {
+    if (Array.isArray(a)) {
+      var _i = 0;
+      while(true) {
+        var i = _i;
+        if (i === len_a) {
+          return true;
         }
-        }(b,result));
-        var do_key_b = (function(a,b,result){
-        return function do_key_b(key) {
-          if (!a.hasOwnProperty(key) || !caml_equal(b[key], a[key])) {
-            result.contents = false;
-            return ;
-          }
-          
+        if (!caml_equal(a[i], b[i])) {
+          return false;
         }
-        }(a,b,result));
-        for_in(a, do_key_a);
-        if (result.contents) {
-          for_in(b, do_key_b);
+        _i = i + 1 | 0;
+        continue ;
+      };
+    } else if ((a instanceof Date && b instanceof Date)) {
+      return !(a > b || a < b);
+    } else {
+      var result = {
+        contents: true
+      };
+      var do_key_a = function (key) {
+        if (!b.hasOwnProperty(key)) {
+          result.contents = false;
+          return ;
         }
-        return result.contents;
+        
+      };
+      var do_key_b = function (key) {
+        if (!a.hasOwnProperty(key) || !caml_equal(b[key], a[key])) {
+          result.contents = false;
+          return ;
+        }
+        
+      };
+      for_in(a, do_key_a);
+      if (result.contents) {
+        for_in(b, do_key_b);
       }
-    } else {
-      return false;
+      return result.contents;
     }
-  };
+  } else {
+    return false;
+  }
 }
 
 function caml_equal_null(x, y) {

lib/js/caml_obj.js

@@ -255,104 +255,88 @@ function caml_compare(a, b) {
   }
 }
 
-function caml_equal(_a, _b) {
-  while(true) {
-    var b = _b;
-    var a = _a;
-    if (a === b) {
-      return true;
-    }
-    var a_type = typeof a;
-    if (a_type === "string" || a_type === "number" || a_type === "boolean" || a_type === "undefined" || a === null) {
-      return false;
-    }
-    var b_type = typeof b;
-    if (a_type === "function" || b_type === "function") {
-      throw {
-            RE_EXN_ID: "Invalid_argument",
-            _1: "equal: functional value",
-            Error: new Error()
-          };
-    }
-    if (b_type === "number" || b_type === "undefined" || b === null) {
-      return false;
-    }
-    var tag_a = a.tag | 0;
-    var tag_b = b.tag | 0;
-    if (tag_a === 250) {
-      _a = a[0];
-      continue ;
-    }
-    if (tag_b === 250) {
-      _b = b[0];
-      continue ;
-    }
-    if (tag_a === 248) {
-      return a[1] === b[1];
-    }
-    if (tag_a === 251) {
-      throw {
-            RE_EXN_ID: "Invalid_argument",
-            _1: "equal: abstract value",
-            Error: new Error()
-          };
-    }
-    if (tag_a !== tag_b) {
-      return false;
-    }
-    if (tag_a === 256) {
-      return a[1] === b[1];
-    }
-    var len_a = a.length | 0;
-    var len_b = b.length | 0;
-    if (len_a === len_b) {
-      if (Array.isArray(a)) {
-        var _i = 0;
-        while(true) {
-          var i = _i;
-          if (i === len_a) {
-            return true;
-          }
-          if (!caml_equal(a[i], b[i])) {
-            return false;
-          }
-          _i = i + 1 | 0;
-          continue ;
+function caml_equal(a, b) {
+  if (a === b) {
+    return true;
+  }
+  var a_type = typeof a;
+  if (a_type === "string" || a_type === "number" || a_type === "boolean" || a_type === "undefined" || a === null) {
+    return false;
+  }
+  var b_type = typeof b;
+  if (a_type === "function" || b_type === "function") {
+    throw {
+          RE_EXN_ID: "Invalid_argument",
+          _1: "equal: functional value",
+          Error: new Error()
         };
-      } else if ((a instanceof Date && b instanceof Date)) {
-        return !(a > b || a < b);
-      } else {
-        var result = {
-          contents: true
+  }
+  if (b_type === "number" || b_type === "undefined" || b === null) {
+    return false;
+  }
+  var tag_a = a.tag | 0;
+  var tag_b = b.tag | 0;
+  if (tag_a === 248) {
+    return a[1] === b[1];
+  }
+  if (tag_a === 251) {
+    throw {
+          RE_EXN_ID: "Invalid_argument",
+          _1: "equal: abstract value",
+          Error: new Error()
         };
-        var do_key_a = (function(b,result){
-        return function do_key_a(key) {
-          if (!b.hasOwnProperty(key)) {
-            result.contents = false;
-            return ;
-          }
-          
+  }
+  if (tag_a !== tag_b) {
+    return false;
+  }
+  if (tag_a === 256) {
+    return a[1] === b[1];
+  }
+  var len_a = a.length | 0;
+  var len_b = b.length | 0;
+  if (len_a === len_b) {
+    if (Array.isArray(a)) {
+      var _i = 0;
+      while(true) {
+        var i = _i;
+        if (i === len_a) {
+          return true;
         }
-        }(b,result));
-        var do_key_b = (function(a,b,result){
-        return function do_key_b(key) {
-          if (!a.hasOwnProperty(key) || !caml_equal(b[key], a[key])) {
-            result.contents = false;
-            return ;
-          }
-          
+        if (!caml_equal(a[i], b[i])) {
+          return false;
         }
-        }(a,b,result));
-        for_in(a, do_key_a);
-        if (result.contents) {
-          for_in(b, do_key_b);
+        _i = i + 1 | 0;
+        continue ;
+      };
+    } else if ((a instanceof Date && b instanceof Date)) {
+      return !(a > b || a < b);
+    } else {
+      var result = {
+        contents: true
+      };
+      var do_key_a = function (key) {
+        if (!b.hasOwnProperty(key)) {
+          result.contents = false;
+          return ;
         }
-        return result.contents;
+        
+      };
+      var do_key_b = function (key) {
+        if (!a.hasOwnProperty(key) || !caml_equal(b[key], a[key])) {
+          result.contents = false;
+          return ;
+        }
+        
+      };
+      for_in(a, do_key_a);
+      if (result.contents) {
+        for_in(b, do_key_b);
       }
-    } else {
-      return false;
+      return result.contents;
     }
-  };
+  } else {
+    return false;
+  }
 }
 
 function caml_equal_null(x, y) {