Skip to content

Commit 7eef482

Browse files
committed
remove the cycle between stdlib and runtime
Now: runtime -> others -> stdlib
1 parent 821972f commit 7eef482

13 files changed

+22
-30
lines changed

Makefile

-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ world:
1919

2020
libs:
2121
@echo "Making compiler finished"
22-
$(MAKE) -C jscomp/stdlib -j $(NPROCS) allcmis
2322
$(MAKE) -C jscomp/runtime -j $(NPROCS) all
2423
$(MAKE) -C jscomp/others -j $(NPROCS) all
2524
$(MAKE) -C jscomp/stdlib -j $(NPROCS) all

jscomp/Makefile

-4
Original file line numberDiff line numberDiff line change
@@ -623,10 +623,6 @@ bootbspack:
623623
@echo "Rebuilding bspack.exe finsihed"
624624

625625
libs:
626-
@echo "Making stdlib cmis"
627-
cd stdlib && $(MAKE) allcmis
628-
@echo "Making stdlib finished"
629-
630626
@echo "Making runtime"
631627
cd runtime && $(MAKE) all
632628
@echo "Making runtime finished"

jscomp/others/Makefile

+1-4
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,6 @@ SOURCE_LIST= node_path node_fs node_process dict node_module js_array js_string
5858
belt_HashMapString\
5959
belt_Debug\
6060

61-
# belt_Bag\
62-
# belt_BagM\
63-
# belt_dyn belt_dyn_lib\
6461

6562
$(addsuffix .cmj, $(SOURCE_LIST)): $(addsuffix .cmj, $(MAP_FILES))
6663

@@ -71,7 +68,7 @@ BS_COMMON_FLAGS= -no-alias-deps -bs-no-version-header -absname -bs-diagnose -bs-
7168

7269
BS_FLAGS= $(BS_COMMON_FLAGS) $(BS_PKG_FLAGS)
7370

74-
COMPFLAGS += $(BS_FLAGS) -I ../runtime -I ../stdlib -w +3-40-49 -warn-error A -bin-annot
71+
COMPFLAGS += -I ../runtime -nostdlib -nopervasives -open Bs_stdlib_mini $(BS_FLAGS) -w +3-40-49 -warn-error A -bin-annot
7572

7673

7774
node.cmi : $(COMPILER)

jscomp/others/belt_Array.ml

+11-11
Original file line numberDiff line numberDiff line change
@@ -183,10 +183,10 @@ let slice a ~offset ~len =
183183
let lena = length a in
184184
let ofs =
185185
if offset < 0 then
186-
max (lena + offset) 0
186+
Pervasives.max (lena + offset) 0
187187
else offset in
188188
let hasLen = lena - ofs in
189-
let copyLength = min hasLen len in
189+
let copyLength = Pervasives.min hasLen len in
190190
if copyLength <= 0 then [||]
191191
else
192192
let result = makeUninitializedUnsafe copyLength in
@@ -197,7 +197,7 @@ let slice a ~offset ~len =
197197

198198
let sliceToEnd a offset =
199199
let lena = length a in
200-
let ofs = if offset < 0 then max (lena + offset) 0 else offset in
200+
let ofs = if offset < 0 then Pervasives.max (lena + offset) 0 else offset in
201201
let len = lena - ofs in
202202
let result = makeUninitializedUnsafe len in
203203
for i = 0 to len - 1 do
@@ -210,10 +210,10 @@ let fill a ~offset ~len v =
210210
let lena = length a in
211211
let ofs =
212212
if offset < 0 then
213-
max (lena + offset ) 0
213+
Pervasives.max (lena + offset ) 0
214214
else offset in
215215
let hasLen = lena - ofs in
216-
let fillLength = min hasLen len in
216+
let fillLength = Pervasives.min hasLen len in
217217
if fillLength > 0 then
218218
for i = ofs to ofs + fillLength - 1 do
219219
setUnsafe a i v
@@ -236,10 +236,10 @@ let blitUnsafe ~src:a1 ~srcOffset:srcofs1 ~dst:a2 ~dstOffset:srcofs2 ~len:blitL
236236
let blit ~src:a1 ~srcOffset:ofs1 ~dst:a2 ~dstOffset:ofs2 ~len =
237237
let lena1 = length a1 in
238238
let lena2 = length a2 in
239-
let srcofs1 = if ofs1 < 0 then max (lena1 + ofs1) 0 else ofs1 in
240-
let srcofs2 = if ofs2 < 0 then max (lena2 + ofs2) 0 else ofs2 in
239+
let srcofs1 = if ofs1 < 0 then Pervasives.max (lena1 + ofs1) 0 else ofs1 in
240+
let srcofs2 = if ofs2 < 0 then Pervasives.max (lena2 + ofs2) 0 else ofs2 in
241241
let blitLength =
242-
min len (min (lena1 - srcofs1) (lena2 - srcofs2)) in
242+
Pervasives.min len (Pervasives.min (lena1 - srcofs1) (lena2 - srcofs2)) in
243243
(* blitUnsafe a1 srcofs1 a2 srcofs2 blitLength *)
244244
(if srcofs2 <= srcofs1 then
245245
for j = 0 to blitLength - 1 do
@@ -353,7 +353,7 @@ let reduceReverse a x f = reduceReverseU a x (fun[@bs] a b -> f a b)
353353

354354
let reduceReverse2U a b x f =
355355
let r = ref x in
356-
let len = min (length a) (length b) in
356+
let len = Pervasives.min (length a) (length b) in
357357
for i = len - 1 downto 0 do
358358
r := f !r (getUnsafe a i) (getUnsafe b i) [@bs]
359359
done;
@@ -409,12 +409,12 @@ let rec someAux2 arr1 arr2 i b len =
409409

410410

411411
let every2U a b p =
412-
everyAux2 a b 0 p (min (length a) (length b))
412+
everyAux2 a b 0 p (Pervasives.min (length a) (length b))
413413

414414
let every2 a b p = every2U a b (fun[@bs] a b -> p a b)
415415

416416
let some2U a b p =
417-
someAux2 a b 0 p (min (length a) (length b))
417+
someAux2 a b 0 p (Pervasives.min (length a) (length b))
418418

419419
let some2 a b p = some2U a b (fun [@bs] a b -> p a b)
420420

jscomp/others/belt_MutableSet.ml

+1-1
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ let intersect a b : _ t =
311311
)
312312
then S.t ~cmp ~data:N.empty
313313
else
314-
let tmp2 = A.makeUninitializedUnsafe (min sizea sizeb) in
314+
let tmp2 = A.makeUninitializedUnsafe (Pervasives.min sizea sizeb) in
315315
let k = Sort.intersectU tmp 0 sizea tmp sizea sizeb tmp2 0 p in
316316
S.t ~data:(N.fromSortedArrayAux tmp2 0 k)
317317
~cmp

jscomp/others/belt_MutableSetInt.ml

+1-1
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,7 @@ let intersect dataa datab =
290290
)
291291
then make ()
292292
else
293-
let tmp2 = A.makeUninitializedUnsafe (min sizea sizeb) in
293+
let tmp2 = A.makeUninitializedUnsafe (Pervasives.min sizea sizeb) in
294294
let k = S.intersect tmp 0 sizea tmp sizea sizeb tmp2 0 in
295295
t ~data:(N.fromSortedArrayAux tmp2 0 k)
296296

jscomp/others/belt_MutableSetString.ml

+1-1
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,7 @@ let intersect dataa datab =
290290
)
291291
then make ()
292292
else
293-
let tmp2 = A.makeUninitializedUnsafe (min sizea sizeb) in
293+
let tmp2 = A.makeUninitializedUnsafe (Pervasives.min sizea sizeb) in
294294
let k = S.intersect tmp 0 sizea tmp sizea sizeb tmp2 0 in
295295
t ~data:(N.fromSortedArrayAux tmp2 0 k)
296296

jscomp/others/belt_internalAVLset.ml

+1-1
Original file line numberDiff line numberDiff line change
@@ -613,7 +613,7 @@ let balMutate nt =
613613
)
614614
else
615615
begin
616-
heightSet nt (max hl hr + 1);
616+
heightSet nt (Pervasives.max hl hr + 1);
617617
nt
618618
end
619619

jscomp/others/belt_internalAVLtree.ml

+1-1
Original file line numberDiff line numberDiff line change
@@ -710,7 +710,7 @@ let balMutate nt =
710710
)
711711
else
712712
begin
713-
heightSet nt (max hl hr + 1);
713+
heightSet nt (Pervasives.max hl hr + 1);
714714
nt
715715
end
716716

jscomp/others/js_math.ml

+2-2
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,8 @@ let unsafe_ceil = unsafe_ceil_int
8383
[@@ocaml.deprecated "Please use `unsafe_ceil_int` instead"]
8484
(** smallest int greater than or equal to the argument *)
8585
let ceil_int f =
86-
if f > Pervasives.float Js_int.max then Js_int.max
87-
else if f < Pervasives.float Js_int.min then Js_int.min
86+
if f > float Js_int.max then Js_int.max
87+
else if f < float Js_int.min then Js_int.min
8888
else unsafe_ceil_int f
8989
let ceil = ceil_int
9090
[@@ocaml.deprecated "Please use `ceil_int` instead"]

jscomp/others/setm.cppo.ml

+1-1
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,7 @@ let intersect dataa datab =
294294
)
295295
then make ()
296296
else
297-
let tmp2 = A.makeUninitializedUnsafe (min sizea sizeb) in
297+
let tmp2 = A.makeUninitializedUnsafe (Pervasives.min sizea sizeb) in
298298
let k = S.intersect tmp 0 sizea tmp sizea sizeb tmp2 0 in
299299
t ~data:(N.fromSortedArrayAux tmp2 0 k)
300300

jscomp/runtime/bs_stdlib_mini.mli

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ external ( && ) : bool -> bool -> bool = "%sequand"
3131
external not : bool -> bool = "%boolnot"
3232

3333
external raise : exn -> 'a = "%raise"
34-
34+
external ignore : 'a -> unit = "%ignore"
3535
external fst : 'a * 'b -> 'a = "%field0"
3636
external snd : 'a * 'b -> 'b = "%field1"
3737
external ( |> ) : 'a -> ('a -> 'b) -> 'b = "%revapply"

jscomp/stdlib/Makefile.shared

+1-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ OTHERS=array.cmo list.cmo char.cmo bytes.cmo string.cmo sys.cmo \
6060
unix.cmo unixLabels.cmo \
6161
bigarray.cmo
6262

63-
allcmis:$(OBJS:.cmo=.cmi) std_exit.cmi $(COMPILER)
63+
# allcmis:$(OBJS:.cmo=.cmi) std_exit.cmi $(COMPILER)
6464

6565
all: $(OBJS:.cmo=.cmj) std_exit.cmj $(COMPILER)
6666
# all: stdlib.cma std_exit.cmo

0 commit comments

Comments
 (0)