WIP: external clean up

Author: bobzhang

jscomp/core/js_exp_make.ml

@@ -627,7 +627,7 @@ let rec triple_equal ?comment (e0 : t) (e1 : t ) : t =
     | Bool _ | Number _ | Typeof _
     | Fun _ | Array _ | Caml_block _ )
     when  no_side_effect e1 -> 
-    false_ (* TODO: rename it as [caml_false] *)
+    false_ 
   | 
     (Char_of_int _ | Char_to_int _ 
     | Bool _ | Number _ | Typeof _
@@ -985,22 +985,26 @@ let rec int_comp (cmp : Lam_compat.comparison) ?comment  (e0 : t) (e1 : t) =
       expression_desc = 
         Var (Qualified 
                ({kind = Runtime}, 
-                Some ("caml_int_compare"))); _}, 
+                Some ("int_compare"))); _}, 
       [l;r], _), 
     Number (Int {i = 0l})
     -> int_comp cmp l r (* = 0 > 0 < 0 *)
   | Ceq, Call ({
       expression_desc = 
         Var (Qualified 
                ({id = _; kind = Runtime} as iid, 
-                Some ("caml_compare"))); _} as fn, 
+                Some ("compare"))); _} as fn, 
       ([_;_] as args), call_info), 
     Number (Int {i = 0l})
     -> 
+    (* This is now generalized for runtime modules
+      `RuntimeModule.compare x y = 0 ` -->
+      `RuntimeModule.equal x y`
+    *)
     {e0 with expression_desc =
                Call( 
                  {fn with expression_desc = 
-                            Var(Qualified (iid, Some "caml_equal")) 
+                            Var(Qualified (iid, Some "equal")) 
                  } , args, call_info)}
   | Ceq, Optional_block _,  Undefined
   | Ceq, Undefined, Optional_block _
@@ -1426,7 +1430,8 @@ let resolve_and_apply
     (runtime_call
        Js_runtime_modules.external_polyfill
        "resolve" 
-       [str s ]
+       [str 
+        (if s.[0] = '?' then String.sub s 1 (String.length s - 1) else s) ]
     ) args 
 
 let make_exception (s : string) = 

jscomp/core/lam_analysis.ml

@@ -47,24 +47,23 @@ let rec no_side_effects (lam : Lam.t) : bool =
       | Pccall {prim_name } ->
         begin 
           match prim_name,args with 
-          | ("caml_register_named_value"
+          | (
             (* register to c runtime does not make sense  in ocaml *)
-            | "caml_int64_float_of_bits"
+             "caml_int64_float_of_bits"
             (* more safe to check if arguments are constant *)
             (* non-observable side effect *)    
-            | "caml_sys_get_config"
-            | "caml_sys_get_argv" (* should be fine *)
-            | "caml_string_repeat"
-            | "caml_make_vect"
-            | "caml_create_bytes"
-            | "caml_obj_dup"
+            | "?sys_get_argv" (* should be fine *)
+            | "?string_repeat"
+            | "?make_vect"
+            | "?create_bytes"
+            | "?obj_dup"
             | "caml_array_dup" 
 
-            | "nativeint_add"         
-            | "nativeint_div"
-            | "nativeint_mod"
-            | "nativeint_lsr"  
-            | "nativeint_mul"
+            | "?nativeint_add"         
+            | "?nativeint_div"
+            | "?nativeint_mod"
+            | "?nativeint_lsr"  
+            | "?nativeint_mul"
 
             ), _  -> true 
           | "caml_ml_open_descriptor_in", [Lconst (  (Const_int {i = 0l}))] -> true 

jscomp/core/lam_compile_primitive.ml

@@ -504,7 +504,7 @@ let translate  loc
          [E.str "BS"] Immutable
     )
   | Pduprecord (Record_regular| Record_extension| Record_inlined _ ) -> 
-    Lam_dispatch_primitive.translate loc "caml_obj_dup" args
+    Lam_dispatch_primitive.translate loc "?obj_dup" args
 
   | Plazyforce  
     (* FIXME: we don't inline lazy force or at least