Skip to content

Commit 4f3126c

Browse files
committed
Fix Js.String.match_ return type
Javscript String.prototype.match function can return undefineds for optional capture groups that are not found, which breaks the type annotations since this is not added as a Js.nullable, it's not possible to deal with those undefined values since it can't be passed to Js.Nullable.isNullable.
1 parent d5d46b3 commit 4f3126c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

jscomp/others/js_string.ml

+1-1
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@ external localeCompare : t -> float = "localeCompare" [@@bs.send.pipe: t]
274274
]}
275275
276276
*)
277-
external match_ : Js_re.t -> t array option = "match" [@@bs.send.pipe: t] [@@bs.return {null_to_opt}]
277+
external match_ : Js_re.t -> t Js.nullable array option = "match" [@@bs.send.pipe: t] [@@bs.return {null_to_opt}]
278278

279279
(** [normalize str] returns the normalized Unicode string using Normalization Form Canonical (NFC) Composition.
280280

0 commit comments

Comments
 (0)