Remove string_of_char which is unused

Author: bobzhang

Diff for: jscomp/runtime/bs_string.ml

@@ -34,7 +34,7 @@
 
 (*ATT: this relies on we encode `char' as int *)
 external of_char : char -> string = "String.fromCharCode" 
-[@@bs.val] 
+[@@bs.val]  
 external toUpperCase : string -> string = "toUpperCase" [@@bs.send] 
 external of_int : int -> base:int -> string = "toString" [@@bs.send]
 external of_nativeint : nativeint -> base:int -> string = "toString" [@@bs.send]
@@ -57,21 +57,20 @@ external of_small_int32_array :
 [@@bs.val] [@@bs.splice]   
 
 external lastIndexOf : string -> string -> int = "lastIndexOf"
-[@@bs.send]    
-external of_any : 'a -> string = "String"
-[@@bs.val]
+[@@bs.send] (* used in {!Caml_io} *)
+ 
 
 
 (***********************)
 (* replaced primitives *)
 external length : string -> int = "%string_length"
-external get : string -> int -> char = "%string_safe_get"
-external create : int -> bytes = "caml_create_string"
+(* external get : string -> int -> char = "%string_safe_get" *)
+(* external create : int -> bytes = "caml_create_string" *)
 external unsafe_get : string -> int -> char = "%string_unsafe_get"
 external unsafe_set : bytes -> int -> char -> unit = "%bytes_unsafe_set"
-external unsafe_blit : string -> int ->  bytes -> int -> int -> unit
-  = "caml_blit_string" 
+(* external unsafe_blit : string -> int ->  bytes -> int -> int -> unit
+  = "caml_blit_string"  *)
 
-external unsafe_fill : bytes -> int -> int -> char -> unit
-  = "caml_fill_string" 
+(* external unsafe_fill : bytes -> int -> int -> char -> unit
+  = "caml_fill_string"  *)
 

Diff for: jscomp/runtime/caml_string.ml

@@ -37,13 +37,8 @@ external of_int_array : int array -> bytes = "%identity"
    using {!Bytes.unsafe_set} since for some standard libraries, 
    it might point to ["%string_unsafe_set"]
 *)
-external unsafe_set : bytes -> int -> char -> unit = "%bytes_unsafe_set"
-external unsafe_get : bytes -> int -> char = "%bytes_unsafe_get"
-external length : bytes -> int = "%bytes_length"
 
 
-let string_of_char = Bs_string.of_char
-
 
 let caml_string_get s i= 
   if i >=Bs_string.length s || i < 0  then

Diff for: jscomp/runtime/caml_string.mli

@@ -25,6 +25,6 @@
 val caml_string_get : string -> int -> char 
 val caml_string_get16 : string -> int -> int
 val caml_string_get32 : string -> int -> int
-val string_of_char : char -> string 
+
 
 val get : string -> int -> char 

Diff for: jscomp/test/.depend

@@ -378,7 +378,7 @@ largest_int_flow.cmj :
 lazy_test.cmj : mt.cmj
 lexer_test.cmj : number_lexer.cmj mt.cmj arith_syntax.cmj arith_parser.cmj \
     arith_lexer.cmj
-lib_js_test.cmj : mt.cmj ../runtime/js.cmj ../runtime/bs_string.cmj
+lib_js_test.cmj : mt.cmj ../runtime/js.cmj
 libarg_test.cmj : mt.cmj
 libqueue_test.cmj :
 limits_test.cmj : mt.cmj

Diff for: jscomp/test/bang_primitive.ml

@@ -41,8 +41,7 @@ external of_small_int_array :
     "String.fromCharCode.apply" 
 [@@bs.val]
 
-(* external string_of_char : char -> string = "#string_of_char" *)
-(* string_of_char y  *)
+
 
 let f x y = 
   of_small_int_array x, 0

Diff for: jscomp/test/lib_js_test.ml

@@ -12,9 +12,10 @@ let () =
     Js.log @@ to_json_string [1;2;3];
     Js.log "hey";
   end
-
+external of_any : 'a -> string = "String"
+[@@bs.val]
 let suites = Mt.[
-    "anything_to_string", (fun _ -> Eq("3", Bs_string.of_any 3 ));
+    "anything_to_string", (fun _ -> Eq("3", of_any 3 ));
     (* in js, array is printed as {[ 1,2 ]} without brackets *)    
     (* "array_to_string", (fun _ -> Eq("[0]", Js.anything_to_string [|0|]))     *)
 ]

Diff for: lib/js/caml_string.js

@@ -2,10 +2,6 @@
 
 var Caml_builtin_exceptions = require("./caml_builtin_exceptions.js");
 
-function string_of_char(prim) {
-  return String.fromCharCode(prim);
-}
-
 function caml_string_get(s, i) {
   if (i >= s.length || i < 0) {
     throw [
@@ -39,6 +35,5 @@ function get(s, i) {
 exports.caml_string_get = caml_string_get;
 exports.caml_string_get16 = caml_string_get16;
 exports.caml_string_get32 = caml_string_get32;
-exports.string_of_char = string_of_char;
 exports.get = get;
 /* No side effect */