-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Highlighting of JSX tags #21
Comments
Interesting! That is not working for me. What version of the extension are you using? |
I found out that it is just that my theme didn't color the "editor.tokenColorCustomizations": {
"textMateRules": [
{
"name": "JSX",
"scope": ["entity.name.namespace"],
"settings": {
"foreground": "#80CBC4"
}
},
// you might also want to set this for polymorphic variants
{
"name": "other",
"scope": ["punctuation.definition.keyword"],
"settings": {
"foreground": "#f87086"
}
}
]
} |
@jfrolich thanks for the solution, i also wanted to highlight in my theme jsx element and their attributes but I found out, that with actual grammar this it is not possible yet(?). ![]() ![]() but right now they are not assigned to any scope ![]() Is it bug... or it is something that won't be implemented? PS. I was thinking about it creating new issue, but this is also related to jsx so i thought it might good place to point that out because i think lot's of themes are decorating jsx in this manner |
Hm, i can see that there is already pull request open with adding this feature |
Hi,
I'm testing out the new 1.0 release of the plugin and I am very impressed! It might be already on the radar, but I didn't see an issue for it; the JSX tags are currently not highlighted making the source code harder to read IMO. See attached code sample for the difference:
The text was updated successfully, but these errors were encountered: