Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to definitions in markdown produced by hover? #122

Closed
zth opened this issue Apr 18, 2021 · 2 comments
Closed

Link to definitions in markdown produced by hover? #122

zth opened this issue Apr 18, 2021 · 2 comments

Comments

@zth
Copy link
Collaborator

zth commented Apr 18, 2021

This is a bit related to https://github.com/rescript-lang/rescript-editor-support/issues/135, but, would it be possible to link to the definition of things referenced inside of a hover? A pseudo example:

SomeModule.someType

type someType = {
  id: string,
  name: string,
  timestamp: [Timestamp.t](/some/file/path/SomeModule.res:15:7),
}

I don't know if one can actually link to files with lines and columns like that, but if possible, it'd be a pretty sweet feature.

@cristianoc
Copy link
Collaborator

I was wondering the same. Hover produces a markdown file, and I'm not sure what links inside it should look like to be picked up.

@chenglou chenglou transferred this issue from rescript-lang/rescript-editor-support Apr 24, 2021
@zth
Copy link
Collaborator Author

zth commented Apr 28, 2021

Closing in favor of #142

@zth zth closed this as completed Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants