Skip to content

bs binaries paths are determined wrong in monorepos #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alex35mil opened this issue Sep 21, 2020 · 8 comments
Closed

bs binaries paths are determined wrong in monorepos #10

alex35mil opened this issue Sep 21, 2020 · 8 comments

Comments

@alex35mil
Copy link

let bscPath = path.join(projectRootPath, c.bscPartialPath)

E.g. this wouldn't work for monorepos that use yarn workspaces, b/c binaries are hoisted above the bsconfig's node_modules.

@gaku-sei
Copy link

Second this, it doesn't work in monorepos 😞

A solution in the short term could be to have a "bsb path"/"bsc path" settings maybe? It's something that could be useful anyway 😄

@danwetherald
Copy link

We as well use yarn workspaces and have lost formatting.

@BlueHotDog
Copy link
Contributor

Came here to open the same issue.
Any solution would help as we're really excited to get started using it. looks much more stable, fast. fun. you got me all excited!

@gaku-sei
Copy link

@BlueHotDog you can already get the extension working with monorepos if you use this branch: #16 it works fine so far 😄

@dchambers
Copy link

I worked around this for the time being by adding this package.json config to the sub-project where I'm going to be using ReScript:

"workspaces": {
  "nohoist": ["bs-platform"]
},

and then running:

yarn --force

Alternatively you can do this globally by modifying the workspaces definition in your root package.json from something like this:

"workspaces": ["libs/*"],

to this:

"workspaces": {
  "packages": ["libs/*"],
  "nohoist": ["**/bs-platform"]
},

@BlueHotDog
Copy link
Contributor

We rather wait until this extension stabilizes. this issue is open for 4 months, with open Prs trying to fix this. can any maintain please help here?

@danwetherald
Copy link

Hey guys, check this out if you are using yarn workspaces, I have a PR in that has a current release flag that you can try for vim plug.

rescript-lang/vim-rescript#19

@IwanKaramazow
Copy link
Contributor

We've fixed this and it's released =D
See forum or the release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants