add test for patterns under other patterns, and handle unsetting what pattern we're currently looking for

Author: zth

analysis/src/CompletionFrontEnd.ml

@@ -416,15 +416,14 @@ let completionWithParser1 ~currentFile ~debug ~offset ~path ~posCursor ~text =
     scope :=
       !scope |> Scope.addModule ~name:md.pmd_name.txt ~loc:md.pmd_name.loc
   in
-
   let lookingForPat = ref None in
-
   let setLookingForPat ctxPath =
     lookingForPat :=
       Some (Completable.Cpattern {typ = ctxPath; prefix = ""; nested = None});
     if debug then
       Printf.printf "looking for: %s \n" (Completable.toString (Cpath ctxPath))
   in
+  let unsetLookingForPat = lookingForPat := None in
   let appendNestedPat patternPat =
     match !lookingForPat with
     | Some (Completable.Cpattern ({nested = None} as p)) ->
@@ -477,7 +476,7 @@ let completionWithParser1 ~currentFile ~debug ~offset ~path ~posCursor ~text =
         match exp |> exprToContextPath with
         | None -> ()
         | Some ctxPath -> setLookingForPat ctxPath)
-      | _ -> ()
+      | _ -> unsetLookingForPat
   in
 
   let typedCompletionPat (pat : Parsetree.pattern) =

analysis/tests/src/CompletionPattern.res

@@ -63,3 +63,12 @@ let z = (f, true)
 
 // switch f { | {nest: {}}}
 //                      ^com
+
+let _ = switch f {
+| {first: 123, nest} =>
+  ()
+  // switch nest { | {}}
+  //                  ^com
+  nest.nested
+| _ => false
+}

analysis/tests/src/expected/CompletionPattern.res.txt

@@ -169,7 +169,7 @@ Completable: Cpattern Value[z]=o->tuple($0), recordBody
 
 Complete src/CompletionPattern.res 60:22
 looking for: Cpath Value[f] 
-posCursor:[60:22] posNoWhite:[60:21] Found expr:[60:3->60:25]
+posCursor:[60:22] posNoWhite:[60:21] Found expr:[60:3->73:1]
 posCursor:[60:22] posNoWhite:[60:21] Found pattern:[60:16->60:25]
 Completable: Cpattern Value[f]->recordField(nest)
 [{
@@ -197,3 +197,20 @@ Completable: Cpattern Value[f]->recordField(nest), recordBody
     "documentation": null
   }]
 
+Complete src/CompletionPattern.res 69:22
+looking for: Cpath Value[f] 
+posCursor:[69:22] posNoWhite:[69:21] Found expr:[66:8->73:1]
+posCursor:[69:22] posNoWhite:[69:21] Found expr:[68:2->71:13]
+posCursor:[69:22] posNoWhite:[69:21] Found expr:[69:5->71:13]
+looking for: Cpath Value[nest] 
+posCursor:[69:22] posNoWhite:[69:21] Found expr:[69:5->69:24]
+posCursor:[69:22] posNoWhite:[69:21] Found pattern:[69:21->69:23]
+Completable: Cpattern Value[nest]->recordBody
+[{
+    "label": "nested",
+    "kind": 5,
+    "tags": [],
+    "detail": "nested: bool\n\nnestedRecord",
+    "documentation": null
+  }]
+