Skip to content

Commit ce21051

Browse files
committedMay 10, 2022
update release instructions now that CI builds the vsix for us
1 parent 177ce86 commit ce21051

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed
 

‎CONTRIBUTING.md

+5-5
Original file line numberDiff line numberDiff line change
@@ -167,10 +167,10 @@ In the future, we should consier showing the format errors when `.compiler.log`
167167

168168
Currently the release is vetted and done by @chenglou.
169169

170-
1. Bump the version properly in `package.json` and `server/package.json` and their lockfiles and make a new commit.
170+
1. Bump the version properly in `package.json` and `server/package.json` and their lockfiles. Commit and push the version bump.
171171
2. Make sure @ryyppy is aware of your changes. He needs to sync them over to the vim plugin.
172-
3. Download and unzip the 3 platforms' production binaries from the Github CI. Put them into `server/analysis_binaries`.
173-
4. Use `vsce publish` to publish. Official VSCode guide [here](https://code.visualstudio.com/api/working-with-extensions/publishing-extension). Only @chenglou has the publishing rights right now.
174-
5. Not done! Make a new manual release [here](https://github.com/rescript-lang/rescript-vscode/releases); use `vsce package` to package up a standalone `.vsix` plugin and attach it onto that new release. This is for folks who don't use the VSCode marketplace.
172+
3. Let CI build your version bump commit. Download the autogenerated `.vsix` from that CI run, unzip it, and rename it to `rescript-vscode-<version-number>.vsix` (`rescript-vscode-1.3.0.vsix` for example).
173+
4. Go to the appropriate [VSCode Marketplace Publisher](https://marketplace.visualstudio.com/manage/publishers/chenglou92), select the three dots next to the extension name, and choose `Update`. Upload your `.vsix` there.
174+
5. Not done! Make a new manual release [here](https://github.com/rescript-lang/rescript-vscode/releases), and make sure you attach the generated `.vsix` onto that new release as well. This is for folks who don't use the VSCode marketplace.
175175

176-
For beta releases, skip step 4. Ask folks to try the `.vsix` directly.
176+
For beta releases, ask folks to try the `.vsix` from CI directly.

0 commit comments

Comments
 (0)