Do not report empty modules when transitive reporting is off.

As the only way for a module to be dead would be for it to be empty.

Author: cristianoc

analysis/reanalyze/src/DeadCommon.ml

@@ -406,9 +406,10 @@ let emitWarning ~decl ~message deadWarning =
       WriteDeadAnnotations.addLineAnnotation ~decl
     else None
   in
-  decl.path
-  |> Path.toModuleName ~isType:(decl.declKind |> DeclKind.isType)
-  |> DeadModules.checkModuleDead ~fileName:decl.pos.pos_fname;
+  if Config.reportTransitive then
+    decl.path
+    |> Path.toModuleName ~isType:(decl.declKind |> DeclKind.isType)
+    |> DeadModules.checkModuleDead ~fileName:decl.pos.pos_fname;
   Log_.warning ~loc
     (DeadWarning
        {
@@ -555,9 +556,10 @@ module Decl = struct
         && (Config.reportTransitive || not (hasRefBelow ()))
       in
       if shouldEmitWarning then (
-        decl.path
-        |> Path.toModuleName ~isType:(decl.declKind |> DeclKind.isType)
-        |> DeadModules.checkModuleDead ~fileName:decl.pos.pos_fname;
+        if Config.reportTransitive then
+          decl.path
+          |> Path.toModuleName ~isType:(decl.declKind |> DeclKind.isType)
+          |> DeadModules.checkModuleDead ~fileName:decl.pos.pos_fname;
         emitWarning ~decl ~message name)
 end
 

analysis/tests/src/expected/Dce.res.txt

@@ -1,3 +1,3 @@
 DCE src/Dce.res
-issues:2
+issues:0