Fix issue with references to elements defined in an interface file

Fixes #645

Author: cristianoc

CHANGELOG.md

@@ -39,6 +39,8 @@
 
 - Fix issue where code analysis would not track types in inner modules across implementations and interfaces https://github.com/rescript-association/reanalyze/issues/186
 
+- Fix issue with references to elements defined in an interface file https://github.com/rescript-lang/rescript-vscode/issues/645
+
 ## v1.8.2
 
 #### :rocket: New Feature

analysis/src/Commands.ml

@@ -172,9 +172,11 @@ let references ~path ~pos ~debug =
                  | Some loc -> loc
                  | None -> Uri.toTopLevelLoc uri2
                in
-               Protocol.stringifyLocation
-                 {uri = Uri.toString uri2; range = Utils.cmtLocToRange loc}
-               :: acc)
+               if loc.loc_ghost then acc
+               else
+                 Protocol.stringifyLocation
+                   {uri = Uri.toString uri2; range = Utils.cmtLocToRange loc}
+                 :: acc)
              [])
   in
   print_endline

analysis/tests/src/References.res

@@ -9,3 +9,14 @@ let c = x
 
 let foo = (~xx) => xx + 1
 //                 ^ref
+
+module M: {
+  let aa: int
+} = {
+  let aa = 10
+}
+
+let bb = M.aa
+let cc = bb
+let dd = M.aa
+//          ^ref

analysis/tests/src/expected/References.res.txt

@@ -14,3 +14,9 @@ References src/References.res 9:19
 {"uri": "References.res", "range": {"start": {"line": 9, "character": 19}, "end": {"line": 9, "character": 21}}}
 ]
 
+References src/References.res 20:12
+[
+{"uri": "References.res", "range": {"start": {"line": 18, "character": 11}, "end": {"line": 18, "character": 13}}},
+{"uri": "References.res", "range": {"start": {"line": 20, "character": 11}, "end": {"line": 20, "character": 13}}}
+]
+