Use the pattern path found to trigger completion.

Author: cristianoc

analysis/src/CompletionFrontEnd.ml

@@ -676,10 +676,12 @@ let completionWithParser ~debug ~path ~posCursor ~currentFile ~text =
           (Loc.toString pat.ppat_loc);
       (match pat.ppat_desc with
       | Ppat_construct (lid, _) ->
+        let lidPath = flattenLidCheckDot lid in
         if debug then
           Printf.printf "XXX Ppat_construct %s:%s\n"
-            (flattenLidCheckDot lid |> String.concat ".")
-            (Loc.toString lid.loc)
+            (lidPath |> String.concat ".")
+            (Loc.toString lid.loc);
+        setResult (Cpath (CPId (lidPath, Value)))
       | _ -> ());
       Ast_iterator.default_iterator.pat iterator pat)
   in

analysis/tests/src/expected/Completion.res.txt

@@ -1389,13 +1389,45 @@ posCursor:[362:8] posNoWhite:[362:7] Found expr:[361:2->365:3]
 posCursor:[362:8] posNoWhite:[362:7] Found pattern:[362:7->364:5]
 posCursor:[362:8] posNoWhite:[362:7] Found pattern:[362:7->362:8]
 XXX Ppat_construct T:[362:7->362:8]
-[]
+Completable: Cpath Value[T]
+[{
+    "label": "That",
+    "kind": 4,
+    "tags": [],
+    "detail": "That\n\ntype v =  This | That",
+    "documentation": null
+  }, {
+    "label": "This",
+    "kind": 4,
+    "tags": [],
+    "detail": "This\n\ntype v =  This | That",
+    "documentation": null
+  }, {
+    "label": "TableclothMap",
+    "kind": 9,
+    "tags": [],
+    "detail": "file module",
+    "documentation": null
+  }, {
+    "label": "TypeDefinition",
+    "kind": 9,
+    "tags": [],
+    "detail": "file module",
+    "documentation": null
+  }]
 
 Complete tests/src/Completion.res 373:21
 posCursor:[373:21] posNoWhite:[373:20] Found expr:[371:8->376:3]
 posCursor:[373:21] posNoWhite:[373:20] Found expr:[372:2->376:3]
 posCursor:[373:21] posNoWhite:[373:20] Found pattern:[373:7->375:5]
 posCursor:[373:21] posNoWhite:[373:20] Found pattern:[373:7->373:21]
 XXX Ppat_construct AndThatOther.T:[373:7->373:21]
-[]
+Completable: Cpath Value[AndThatOther, T]
+[{
+    "label": "ThatOther",
+    "kind": 4,
+    "tags": [],
+    "detail": "ThatOther\n\ntype v =  And | ThatOther",
+    "documentation": null
+  }]