Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 7220e9d

Browse files
committedJan 8, 2024
changelog
1 parent dcd2e18 commit 7220e9d

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed
 

‎CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
- Better error recovery when analysis fails. https://github.com/rescript-lang/rescript-vscode/pull/880
1616
- Expand type aliases in hovers. https://github.com/rescript-lang/rescript-vscode/pull/881
1717
- Include fields when completing a braced expr that's an ID, where it the path likely starts with a module. https://github.com/rescript-lang/rescript-vscode/pull/882
18+
- Complete domProps for lowercase JSX components from `ReactDOM.domProps` if possible. https://github.com/rescript-lang/rescript-vscode/pull/883
1819

1920
## 1.32.0
2021

‎analysis/src/CompletionBackEnd.ml

+2
Original file line numberDiff line numberDiff line change
@@ -1585,6 +1585,8 @@ let rec processCompletable ~debug ~full ~scope ~env ~pos ~forHover completable =
15851585
match fromDomProps with
15861586
| Some domProps -> domProps
15871587
| None ->
1588+
if debug then
1589+
Printf.printf "Could not find ReactDOM.domProps to complete from.\n";
15881590
(CompletionJsx.domLabels
15891591
|> List.filter (fun (name, _t) ->
15901592
Utils.startsWith name prefix

0 commit comments

Comments
 (0)
Please sign in to comment.