Skip to content

Commit 1b92b7e

Browse files
committed
Try a better prod binary name
This is so that in activity monitor and other places, they look idiomatic and debuggable
1 parent 505ba07 commit 1b92b7e

File tree

1 file changed

+20
-9
lines changed

1 file changed

+20
-9
lines changed

.github/workflows/ci.yml

+20-9
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,18 @@ jobs:
1212
fail-fast: false
1313
matrix:
1414
os: [macos-latest, ubuntu-latest, windows-latest]
15+
# weird syntax
16+
include:
17+
- os: macos-latest
18+
build: eval $(opam env) && cd analysis && make test
19+
artifact-folder: darwin
20+
- os: ubuntu-latest
21+
build: eval $(opam env) && cd analysis && make test
22+
artifact-folder: linux
23+
- os: windows-latest
24+
# CI windows running the binary somehow stucks. Not sure why. Disable for now.
25+
build: "cd analysis && & $env:CYGWIN_ROOT\\bin\\ocaml-env exec -- make"
26+
artifact-folder: win32
1527

1628
runs-on: ${{matrix.os}}
1729

@@ -41,20 +53,19 @@ jobs:
4153
# - run: opam pin add rescript-editor-support.dev . --no-action
4254
# - run: opam install . --deps-only --with-doc --with-test
4355

44-
- run: eval $(opam env) && cd analysis && make test
45-
if: matrix.os != 'windows-latest'
46-
# CI windows running the binary somehow stucks. Not sure why. Disable for now.
47-
- run: "cd analysis && & $env:CYGWIN_ROOT\\bin\\ocaml-env exec -- make"
48-
if: matrix.os == 'windows-latest'
56+
- name: Build and test
57+
run: ${{matrix.build}}
4958

5059
# Also avoids artifacts upload permission loss:
5160
# https://github.com/actions/upload-artifact/tree/ee69f02b3dfdecd58bb31b4d133da38ba6fe3700#permission-loss
5261
- name: Compress files
53-
run: >
54-
mv analysis/run.exe ${{matrix.os}}-run.exe &&
55-
tar -cvf binary.tar ${{matrix.os}}-run.exe
62+
run: |
63+
cd analysis
64+
mkdir ${{matrix.artifact-folder}}
65+
mv run.exe ${{matrix.artifact-folder}}/rescript-editor-analysis.exe
66+
tar -cvf binary.tar ${{matrix.artifact-folder}}/rescript-editor-analysis.exe
5667
5768
- uses: actions/upload-artifact@v2
5869
with:
59-
name: ${{matrix.os}}-run.exe
70+
name: ${{matrix.os}}
6071
path: binary.tar

0 commit comments

Comments
 (0)